Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently ARF is being overestimated in eSASS srctool command #1289

Open
jessicapilling opened this issue Nov 26, 2024 · 0 comments
Open

Currently ARF is being overestimated in eSASS srctool command #1289

jessicapilling opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jessicapilling
Copy link
Collaborator

In srctool, we currently provide an image to the extmap argument. This image is the combined image from combined eventlists - so it covers a large area.

The way srctool makes it's arf is by dividing this area - given by the extmap argument, into a grid. For each timestep, the effective area is calculated for each point on the grid. Then an overall arf, specific to the area we give to the extmap argument is produced.

Since we give a large image to scrtool currently, we will be overestimating the arf for each spectra.

Solution:
We need to instead mask out the non-cluster parts of the image and give this masked image as the extmap argument.

The size of this mask is up for debate - I think making a radius slightly bigger than the user provided outer_radius argument to srctool_spectrum should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants