Slight optimization

Author: Decane

Optional Features/#1. (Choose From This Folder First)/No Enemy Map Spots/gamedata/scripts/sim_squad_generic.script

@@ -204,11 +204,12 @@ function sim_squad_generic:create_npc(spawn_smart)
 
 	local custom_resource = nil
 	local min_npc, max_npc = 3, 5
+	local spawn_level = spawn_smart.smart_level
 
 	if self.player_id == "monster" then
 
 		local min, max = 0, 5
-		local monster_resource = monster_resource_by_level[spawn_smart.smart_level]
+		local monster_resource = monster_resource_by_level[spawn_level]
 
 		if monster_resource ~= nil then
 			min = monster_resource[1]
@@ -231,7 +232,7 @@ function sim_squad_generic:create_npc(spawn_smart)
 		position.x = position.x + math_random(-2, 2)
 		position.z = position.z + math_random(-2, 2)
 
-		local spawn_section = faction:get_spawn_section(spawn_smart, custom_resource)
+		local spawn_section = faction:get_spawn_section(spawn_level, custom_resource)
 		local obj = sim:create(spawn_section, position, base_lvi, base_gvi)
 		local obj_id = obj.id
 

Optional Features/#2. (Choose From This Folder Last)/Show Only Ally Map Spots/gamedata/scripts/sim_squad_generic.script

@@ -204,11 +204,12 @@ function sim_squad_generic:create_npc(spawn_smart)
 
 	local custom_resource = nil
 	local min_npc, max_npc = 3, 5
+	local spawn_level = spawn_smart.smart_level
 
 	if self.player_id == "monster" then
 
 		local min, max = 0, 5
-		local monster_resource = monster_resource_by_level[spawn_smart.smart_level]
+		local monster_resource = monster_resource_by_level[spawn_level]
 
 		if monster_resource ~= nil then
 			min = monster_resource[1]
@@ -231,7 +232,7 @@ function sim_squad_generic:create_npc(spawn_smart)
 		position.x = position.x + math_random(-2, 2)
 		position.z = position.z + math_random(-2, 2)
 
-		local spawn_section = faction:get_spawn_section(spawn_smart, custom_resource)
+		local spawn_section = faction:get_spawn_section(spawn_level, custom_resource)
 		local obj = sim:create(spawn_section, position, base_lvi, base_gvi)
 		local obj_id = obj.id
 

gamedata/scripts/sim_faction.script

@@ -364,7 +364,7 @@ function se_sim_faction:update()
 --	self:refresh()
 end
 
-function se_sim_faction:get_spawn_section(spawn_smart, custom_resource)
+function se_sim_faction:get_spawn_section(level_name, custom_resource)
 
 	local resource_spawn_data
 	if custom_resource ~= nil then
@@ -387,7 +387,6 @@ function se_sim_faction:get_spawn_section(spawn_smart, custom_resource)
 		end
 	end
 
-	local level_name = spawn_smart.smart_level
 	local level_spawn_data = self.spawn_by_level[level_name]
 
 	if level_spawn_data == nil then

gamedata/scripts/sim_squad_generic.script

@@ -204,11 +204,12 @@ function sim_squad_generic:create_npc(spawn_smart)
 
 	local custom_resource = nil
 	local min_npc, max_npc = 3, 5
+	local spawn_level = spawn_smart.smart_level
 
 	if self.player_id == "monster" then
 
 		local min, max = 0, 5
-		local monster_resource = monster_resource_by_level[spawn_smart.smart_level]
+		local monster_resource = monster_resource_by_level[spawn_level]
 
 		if monster_resource ~= nil then
 			min = monster_resource[1]
@@ -231,7 +232,7 @@ function sim_squad_generic:create_npc(spawn_smart)
 		position.x = position.x + math_random(-2, 2)
 		position.z = position.z + math_random(-2, 2)
 
-		local spawn_section = faction:get_spawn_section(spawn_smart, custom_resource)
+		local spawn_section = faction:get_spawn_section(spawn_level, custom_resource)
 		local obj = sim:create(spawn_section, position, base_lvi, base_gvi)
 		local obj_id = obj.id