We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dipu对有针对部分算子的 custom_fallback 逻辑。
在这个commit将linear的custom_fallback设为true之后。
deeplink.framework/dipu/scripts/autogen_diopi_wrapper/diopi_functions.yaml
Lines 747 to 748 in 583de90
在燧原以及华为上运行llama_finetune时会有如下报错:
由于dipu存在自定义的dispatch逻辑(包括custom_fallback),影响了dynamo中对meta key的dispatch行为,在linear设为custom_fallback后,会影响linear_backward的dispatch行为:
custom_fallback的逻辑主要在这里:
deeplink.framework/dipu/torch_dipu/csrc_dipu/aten/RegisterDIPU.hpp
Lines 63 to 79 in 583de90
The text was updated successfully, but these errors were encountered:
add diopiNormalTensor, diopiNormalScalarTensor, diopiNormalTensorScal…
e7e7095
…ar (DeepLink-org#593)
No branches or pull requests
背景
dipu对有针对部分算子的 custom_fallback 逻辑。
问题描述
在这个commit将linear的custom_fallback设为true之后。
deeplink.framework/dipu/scripts/autogen_diopi_wrapper/diopi_functions.yaml
Lines 747 to 748 in 583de90
在燧原以及华为上运行llama_finetune时会有如下报错:
![image](https://private-user-images.githubusercontent.com/87467364/294074384-5f672d1a-fba8-4c5a-91ee-be38ef8a4e58.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjAzODEsIm5iZiI6MTczOTQ2MDA4MSwicGF0aCI6Ii84NzQ2NzM2NC8yOTQwNzQzODQtNWY2NzJkMWEtZmJhOC00YzVhLTkxZWUtYmUzOGVmOGE0ZTU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1MjEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRmMzg1OTkzM2IwZWM0MWM2NzMxNWE1ZDMyYjZkYjZhNjZkZWYwMzc5OWIxNDg5YTNiZmQ3MWM2OWQzMDQ3OTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pw3x6DYMdXKdKFlnwc0-R9J71pqt_uJFR55wrLmIphY)
问题分析
由于dipu存在自定义的dispatch逻辑(包括custom_fallback),影响了dynamo中对meta key的dispatch行为,在linear设为custom_fallback后,会影响linear_backward的dispatch行为:
![image(1)](https://private-user-images.githubusercontent.com/87467364/294074689-933e2af8-bb57-4b7b-bdf7-eed2da4434de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjAzODEsIm5iZiI6MTczOTQ2MDA4MSwicGF0aCI6Ii84NzQ2NzM2NC8yOTQwNzQ2ODktOTMzZTJhZjgtYmI1Ny00YjdiLWJkZjctZWVkMmRhNDQzNGRlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1MjEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNhZTJmOGEwMGViNzBjZWE1ZGZkNGZhM2Y2YWNlYzlkOTRiZTdlNDI1MDAwYmZmMTQ4OGI0OTEwN2E3ODUyNjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.0vZYFRF5gpartVCQ4ZXE0aMXn3XLvC-wjPm-VOAWzgk)
改进建议
custom_fallback的逻辑主要在这里:
deeplink.framework/dipu/torch_dipu/csrc_dipu/aten/RegisterDIPU.hpp
Lines 63 to 79 in 583de90
通过增设一个环境变量DIPU_DISABLE_CUSTOM_FALLBACK以及disable_custom_fallback_ops_list在必要时禁用custom_fallback的逻辑(默认开启custom_fallback)。
The text was updated successfully, but these errors were encountered: