Skip to content

Task.batch_wait() should return the same Task objects #70

@thomas-riccardi

Description

@thomas-riccardi

Currently Task.batch_wait() returns newly created Task objects (because it goes through ListableResource.list() which exclusively takes pk as argument (and recreates new objects).

I would have expected that my initial Task objects would be directly refreshed by batch_wait().

Solution: make ListableResource.list() also accept class objects, in addition to the current pk, and use that in batch_wait().

This would be a breaking change but that's OK.

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking changeSemVer Major: breaking changedifficulty/easyEasy issue (less than one day)kind/featureNew feature (functional change) or feature enhancementkind/stabilityImpact the reliability/stability of the codepriority/lowIssue to solve at some point

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions