Merge pull request #305 from Deltares/compathelper/new_version/2023-10-05-11-53-02-577-02313901943

CompatHelper: bump compat for NCDatasets to 0.13, (keep existing compat)

Author: JoostBuitink

Project.toml

@@ -38,7 +38,7 @@ Graphs = "1.4"
 IfElse = "0.1"
 LoggingExtras = "0.4.6,0.5,1"
 LoopVectorization = "0.12"
-NCDatasets = "0.12.11"
+NCDatasets = "0.13"
 Parameters = "0.12"
 Polyester = "0.7"
 Polynomials = "3,4"

docs/src/changelog.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Documentation: add leakage term to the wflow\_sbm figure, document external input
   parameter `ksathorfrac` and fix description of adding external `inflow` to the kinematic
   wave.
+- Bump compat for NCDatasets to 0.13.
 
 ### Changed
 - For cyclic parameters different cyclic time inputs are supported (only one common cyclic

test/horizontal_process.jl

@@ -4,7 +4,7 @@ const ldd_mv = 255
 # read the staticmaps into memory
 nc = NCDataset(staticmaps_rhine_path)
 # helper function to get the axis order and directionality right
-read_right(nc, var) = reverse(permutedims(nc[var][:]); dims = 2)
+read_right(nc, var) = reverse(permutedims(Array(nc[var])); dims = 2)
 ldd_2d = read_right(nc, "ldd")
 
 inds, _ = Wflow.active_indices(ldd_2d, ldd_mv)