Skip to content

Commit 42aa906

Browse files
authored
Merge pull request #161 from detsys-pr-bot/detsys-ts-update-8d9725c4856301321cd2508f5b8725cfb99366e2
Update `detsys-ts`: Merge pull request #81 from DeterminateSystems/dont-capture-some-crashes
2 parents 9e4b6cb + 8b0105d commit 42aa906

File tree

2 files changed

+27
-12
lines changed

2 files changed

+27
-12
lines changed

dist/index.js

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -87214,7 +87214,7 @@ var cache = __nccwpck_require__(7389);
8721487214
const external_node_child_process_namespaceObject = __WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:child_process");
8721587215
;// CONCATENATED MODULE: external "node:path"
8721687216
const external_node_path_namespaceObject = __WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:path");
87217-
;// CONCATENATED MODULE: ./node_modules/.pnpm/detsys-ts@https+++codeload.github.com+DeterminateSystems+detsys-ts+tar.gz+38df301720b69_7fd9a17534655bad6bc9b22db661f5b2/node_modules/detsys-ts/dist/index.js
87217+
;// CONCATENATED MODULE: ./node_modules/.pnpm/detsys-ts@https+++codeload.github.com+DeterminateSystems+detsys-ts+tar.gz+8d9725c485630_cc2c1096494a1fd83f38014785db8a80/node_modules/detsys-ts/dist/index.js
8721887218
var __defProp = Object.defineProperty;
8721987219
var __export = (target, all) => {
8722087220
for (var name in all)
@@ -87442,16 +87442,24 @@ function stringifyError(e) {
8744287442

8744387443

8744487444
var START_SLOP_SECONDS = 5;
87445-
async function collectBacktraces(prefixes, startTimestampMs) {
87445+
async function collectBacktraces(prefixes, programNameDenyList, startTimestampMs) {
8744687446
if (isMacOS) {
87447-
return await collectBacktracesMacOS(prefixes, startTimestampMs);
87447+
return await collectBacktracesMacOS(
87448+
prefixes,
87449+
programNameDenyList,
87450+
startTimestampMs
87451+
);
8744887452
}
8744987453
if (isLinux) {
87450-
return await collectBacktracesSystemd(prefixes, startTimestampMs);
87454+
return await collectBacktracesSystemd(
87455+
prefixes,
87456+
programNameDenyList,
87457+
startTimestampMs
87458+
);
8745187459
}
8745287460
return /* @__PURE__ */ new Map();
8745387461
}
87454-
async function collectBacktracesMacOS(prefixes, startTimestampMs) {
87462+
async function collectBacktracesMacOS(prefixes, programNameDenyList, startTimestampMs) {
8745587463
const backtraces = /* @__PURE__ */ new Map();
8745687464
try {
8745787465
const { stdout: logJson } = await exec.getExecOutput(
@@ -87493,6 +87501,10 @@ async function collectBacktracesMacOS(prefixes, startTimestampMs) {
8749387501
for (const [source, dir] of dirs) {
8749487502
const fileNames = (await (0,promises_namespaceObject.readdir)(dir)).filter((fileName) => {
8749587503
return prefixes.some((prefix) => fileName.startsWith(prefix));
87504+
}).filter((fileName) => {
87505+
return !programNameDenyList.some(
87506+
(programName) => fileName.startsWith(`${programName}_${(/* @__PURE__ */ new Date()).getFullYear()}`)
87507+
);
8749687508
}).filter((fileName) => {
8749787509
return !fileName.endsWith(".diag");
8749887510
});
@@ -87517,7 +87529,7 @@ async function collectBacktracesMacOS(prefixes, startTimestampMs) {
8751787529
}
8751887530
return backtraces;
8751987531
}
87520-
async function collectBacktracesSystemd(prefixes, startTimestampMs) {
87532+
async function collectBacktracesSystemd(prefixes, programNameDenyList, startTimestampMs) {
8752187533
const sinceSeconds = Math.ceil((Date.now() - startTimestampMs) / 1e3) + START_SLOP_SECONDS;
8752287534
const backtraces = /* @__PURE__ */ new Map();
8752387535
const coredumps = [];
@@ -87539,7 +87551,7 @@ async function collectBacktracesSystemd(prefixes, startTimestampMs) {
8753987551
if (typeof sussyObject.exe == "string" && typeof sussyObject.pid == "number") {
8754087552
const execParts = sussyObject.exe.split("/");
8754187553
const binaryName = execParts[execParts.length - 1];
87542-
if (prefixes.some((prefix) => binaryName.startsWith(prefix))) {
87554+
if (prefixes.some((prefix) => binaryName.startsWith(prefix)) && !programNameDenyList.includes(binaryName)) {
8754387555
coredumps.push({
8754487556
exe: sussyObject.exe,
8754587557
pid: sussyObject.pid
@@ -88107,6 +88119,7 @@ var STATE_KEY_CROSS_PHASE_ID = "detsys_cross_phase_id";
8810788119
var STATE_BACKTRACE_START_TIMESTAMP = "detsys_backtrace_start_timestamp";
8810888120
var DIAGNOSTIC_ENDPOINT_TIMEOUT_MS = 1e4;
8810988121
var CHECK_IN_ENDPOINT_TIMEOUT_MS = 1e3;
88122+
var PROGRAM_NAME_CRASH_DENY_LIST = ["nix-expr-tests"];
8811088123
var DetSysAction = class {
8811188124
determineExecutionPhase() {
8811288125
const currentPhase = core.getState(STATE_KEY_EXECUTION_PHASE);
@@ -88654,6 +88667,7 @@ var DetSysAction = class {
8865488667
}
8865588668
const backtraces = await collectBacktraces(
8865688669
this.actionOptions.binaryNamePrefixes,
88670+
this.actionOptions.binaryNamesDenyList,
8865788671
parseInt(core.getState(STATE_BACKTRACE_START_TIMESTAMP))
8865888672
);
8865988673
core.debug(`Backtraces identified: ${backtraces.size}`);
@@ -88798,7 +88812,8 @@ function makeOptionsConfident(actionOptions) {
8879888812
"nix",
8879988813
"determinate-nixd",
8880088814
actionOptions.name
88801-
]
88815+
],
88816+
binaryNamesDenyList: actionOptions.binaryNamePrefixes ?? PROGRAM_NAME_CRASH_DENY_LIST
8880288817
};
8880388818
core.debug("idslib options:");
8880488819
core.debug(JSON.stringify(finalOpts, void 0, 2));

pnpm-lock.yaml

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)