Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line624 in rouge.py may be incorrect? #13

Open
JialeGuo opened this issue Nov 20, 2019 · 1 comment
Open

line624 in rouge.py may be incorrect? #13

JialeGuo opened this issue Nov 20, 2019 · 1 comment

Comments

@JialeGuo
Copy link

score = Rouge._compute_p_r_f_score(total_hypothesis_ngrams_count, total_reference_ngrams_count, total_ngrams_overlapping_count, self.alpha, self.weight_factor if use_w else 1.0)

may change to:
score = Rouge._compute_p_r_f_score(hypothesis_count, reference_count, overlapping_ngrams, self.alpha, self.weight_factor if use_w else 1.0)

Since "total_hypothesis_ngrams_count, total_reference_ngrams_count, total_ngrams_overlapping_count" have not been defined yet in this if-else brunch.

@manikbhandari
Copy link

I'm facing the same issue. Is this the right fix?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants