-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave program
Description
Description
Add a test that create_vault accepts success_destination == failure_destination (e.g. same address) and that release_funds and redirect_funds both send to that address when applicable.
Requirements and context
- Must be secure, tested, and documented
- Should be efficient and easy to review
Suggested execution
- Fork the repo and create a branch
git checkout -b test/same-success-failure-destination- Implement changes
- Create vault with success_destination = failure_destination = X, run release and (in another vault) redirect, assert X receives funds
- Test and commit
- Run tests
- Include test output and security notes
- Example commit message:
test: success_destination and failure_destination can be same address
Guidelines
- Minimum 95 percent test coverage
- Clear documentation
- Timeframe: 96 hours
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave program