Rename all occurences of annotation to attribute

Author: bobvandevijver

composer-require-checker.json

@@ -7,7 +7,6 @@
     "BOMO\\IcalBundle\\Model\\Event",
     "BOMO\\IcalBundle\\Model\\Timezone",
     "BOMO\\IcalBundle\\Provider\\IcsProvider",
-    "Doctrine\\Common\\Annotations\\AnnotationReader",
     "Doctrine\\Common\\Collections\\Collection",
     "Doctrine\\Common\\EventSubscriber",
     "Doctrine\\DBAL\\Platforms\\AbstractPlatform",

config/packages/drenso_shared.yaml

@@ -30,7 +30,7 @@ drenso_shared:
       enabled: false # Enable the JMS twig integration (automatically true when you specify any of the options below and omit this line)
   services:
     feature_flags:
-      enabled: true # Enable the feature flags service and annotations (automatically true when you specify any of the options below and omit this line)
+      enabled: true # Enable the feature flags service and attributes (automatically true when you specify any of the options below and omit this line)
       configuration_file: '' # The JSON file location where your flags are configured, for example '%env(resolve:FEATURES_FILE)%'
       configuration_local_file: '' # Not required, but can be used to override flags in the main configuration file outside of version control
     gravatar:

src/Command/CheckActionSecurityCommand.php

@@ -91,9 +91,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         // Create ReflectionMethod
         $reflectedMethod = new ReflectionMethod($controllerObject, $action);
         $attrFlags       = ReflectionAttribute::IS_INSTANCEOF;
-        // Check if Route annotation exists
+        // Check if Route attribute exists
         if ($reflectedMethod->getAttributes(Route::class, $attrFlags)) {
-          // Check if Security or IsGranted annotation exists, if not raise error
+          // Check if Security or IsGranted attribute exists, if not raise error
           if (!$reflectedMethod->getAttributes(Security::class, $attrFlags) &&
               !$reflectedMethod->getAttributes(IsGranted::class, $attrFlags) &&
               (!$allowClass || !(new ReflectionClass($controllerObject))->getAttributes(IsGranted::class, $attrFlags))) {
@@ -110,7 +110,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     if (!empty($noSecurity)) {
       $error = [];
       // Concatenate non-pre-authorized methods
-      $error[] = 'The following methods do not contain a Security or IsGranted annotation:';
+      $error[] = 'The following methods do not contain a Security or IsGranted attribute:';
       $error   = [...$error, ...$noSecurity];
 
       // Feedback error
@@ -120,7 +120,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     }
 
     // No errors occurred!
-    $io->success('All methods contain a Security or IsGranted annotation!');
+    $io->success('All methods contain a Security or IsGranted attribute!');
 
     if ($output->isVerbose()) {
       $output->writeln("Checked controllers:");

src/FeatureFlags/RequireFeatureListener.php

@@ -20,14 +20,14 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event)
   {
     $request = $event->getRequest();
 
-    /** @var $annotations RequireFeature[] */
-    if (!$annotations = $request->attributes->get('_drenso_require_feature')) {
+    /** @var $attributes RequireFeature[] */
+    if (!$attributes = $request->attributes->get('_drenso_require_feature')) {
       return;
     }
 
-    foreach ($annotations as $annotation) {
-      if (!$this->featureFlags->getFlagValue($annotation->flag)) {
-        throw new NotFoundHttpException(sprintf('Feature disabled (%s)', $annotation->flag));
+    foreach ($attributes as $attribute) {
+      if (!$this->featureFlags->getFlagValue($attribute->flag)) {
+        throw new NotFoundHttpException(sprintf('Feature disabled (%s)', $attribute->flag));
       }
     }
   }

src/LockableController/UseLockListener.php

@@ -29,13 +29,13 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event)
   {
     $request = $event->getRequest();
 
-    /** @var $annotations UseLock[] */
-    if (!$annotations = $request->attributes->get('_drenso_use_lock')) {
+    /** @var $attributes UseLock[] */
+    if (!$attributes = $request->attributes->get('_drenso_use_lock')) {
       return;
     }
 
-    foreach ($annotations as $annotation) {
-      $lock = $this->lockFactory->createLock($annotation->lockName);
+    foreach ($attributes as $attribute) {
+      $lock = $this->lockFactory->createLock($attribute->lockName);
       $lock->acquire(true);
       $this->locks[] = $lock;
     }