Hey @liux3372 , I merged your branch because I think it's got everything it needs and I have no objections. Well done in fact - I can see a lot of work went into it.
Here are some comments:
- For
warcraft3, is the DataProcessor necessary? Looks like we only use the DataSpliter (btw, it should be 'DataSplitter' - two t's) for that.
- It's interesting that warcraft3 has a AUC of 63% and boxing has an AUC of 74.6%. The calibration plots would suggest warcraft 3 should be better. What do you think? You reasonable sure these numbers are correct?
- Can you update the
README.md with instructions on how someone else can run through these notebooks? I'd make sure to write them as you run through them yourself.
- Can you delete anything that you think is unused? E.g. maybe the Warcraft3 DataProcessor. But also outdated graphics or whatever else. I'm not sure if there is a lot of delete-able stuff - I'm just trying to cut down on what I have to look.
Hey @liux3372 , I merged your branch because I think it's got everything it needs and I have no objections. Well done in fact - I can see a lot of work went into it.
Here are some comments:
warcraft3, is the DataProcessor necessary? Looks like we only use the DataSpliter (btw, it should be 'DataSplitter' - two t's) for that.README.mdwith instructions on how someone else can run through these notebooks? I'd make sure to write them as you run through them yourself.