-
Notifications
You must be signed in to change notification settings - Fork 4
Add grand list and remove two table pages #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add grand list and remove two table pages #657
Conversation
FionaDyalog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to implementing feedback
| !!! Hint "Hints and Recommendations" | ||
| Dyalog can extend any of these facilities by, for example, adding extra elements, rows, or columns to a result, so code should take this possibility into account. | ||
|
|
||
| |Name |Description |Syntax| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced that "Syntax" is the correct label for the third column. I'm failing to come up with a viable alternative at the moment though. Let's discuss...
|
This looks safe in terms of CHM. For PDF, paged rendering of large tables will almost certainly look really bad. My controversial take is -- do we even need it at all? We already have a nice ToC, now properly and predictably ordered. |
It maintains consistency between sections (not the primary reason, but good to have) and includes information that is not in the ToC. As it does not mess uyp the CHM I would like it to go haead. However, your comment about the PDF is very valid. We could hold off on this until Dyalog v21.0 when that issue will resovle itself. Leave it with me. @abrudz – after implementing feedback please do not merge this in but wait until I confirm. Thanks. |
xpqz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No description provided.