Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: website recall rule function #59

Open
agungism opened this issue Feb 22, 2024 · 1 comment
Open

feat: website recall rule function #59

agungism opened this issue Feb 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@agungism
Copy link

Describe the bug
When accessing a normal video (not a short video) on the YouTube website. The Logseq Copilot icon displays incorrect numbers. This behavior only occurs on the YouTube website, while other websites function normally.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'youtube.com' in internet browser
  2. Open any video (not short)
  3. View the Logseq Copilot icon
  4. Pay attention to the numbers displayed

Expected behavior
The Logseq Copilot icon should not display any numbers if the video we are watching is a video that has not been clipped. If the video has been clipped (for example 3 times) then the number that appears should be 3.

Screenshots

I have never clipped this video. But look at the number displayed by Logseq Copilot, 208.
Screen Shot 2024-02-22 at 20 27 49

I've already clipped this video once. But Logseq Copilot displays the number 208 instead of 1.
Screen Shot 2024-02-22 at 20 33 38

I've clipped this short twice. Logseq Copilot displays the number correctly which is 2.
Screen Shot 2024-02-22 at 20 10 19

This is an example from another website, Github. I have already clipped this webpage once. And Logseq Copilot displays the correct number, which is 1.
Screen Shot 2024-02-22 at 15 18 35

Desktop:

  • OS: MacOS 10.15.7 (19H2026)
  • Browser: Chrome 122.0.6261.57 (Official Build) (x86_64)
  • Logseq Copilot 1.13.2
  • Logseq 0.10.6
@EINDEX EINDEX added the enhancement New feature or request label Feb 25, 2024
@EINDEX
Copy link
Owner

EINDEX commented Mar 2, 2024

This number logic needs discussion with #41, we need to maintain a website rule for this feature.

@EINDEX EINDEX changed the title Youtube does not display correct numbers on Logseq Copilot icon feat: website recall rule function Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants