De-selecting time does not automatically remove time *constraints from url

[sammertime]

Hi there,

I just wanted to point out a *possible low priority bug. We recently upgraded our version of ERDDAP to 2.25.1 (axiom/docker-erddap:2.25.1-jdk21-openjdk) and noticed that when de-selecting the time variable in the tabledap > Data Access Form, the "time" is removed from the url after generating it but the "time constraints" remain in the generated url. We *think this wasn't the case previously, but it's possible this is expected behavior? Our assumption was that de-selecting time would remove all time components from the generated url. We noticed it because we ran into issues with no data being returned due to those time constraints remaining in the url.

Again, low priority but wanted to point it out in case it is in fact a bug.

This is the case for Chrome Version 133.0.6943.141 (Official Build) (arm64) on a mac.

A screenshot is attached indicating the issue.

Thanks for your time!

Best,
Sam

[ChrisJohnNOAA]

I don't know of any intention to change that behavior. I did just check on a server several versions behind and it has the same behavior.

I understand the current behavior is a little surprising, but it's also possible somebody would want to constrain a variable that they do not request in the output. One possible solution would be to change the UI to make it clearer that including the variable and applying the constraint are two separate decisions (and make it easier to clear the constraints).

[sammertime]

No problem @ChrisJohnNOAA and thank you for the prompt reply! We will move forward with this in mind : )

Cheers,
Sam

[ChrisJohnNOAA]

The plan to improve this is to add a column of checkboxes (similar to the variable column). It should be titled "Apply Constraint" and there should be a button to "Uncheck All". The main goal here is to allow users to choose not to apply a constraint.

To add this the "writeDapHtmlForm" method in both EDDTable and EDDGrid will need to be updated.

[Anees02]

Hello @ChrisJohnNOAA ! I don't get the idea .
Can you help me

[ChrisJohnNOAA]

@Anees02 What are you stuck on? What doesn't make sense?

[Anees02]

@ChrisJohnNOAA
From the plan what I understand was!

1. Add a column for each row i.e a checkbox
2. The title of the column is apply constraint with unchecked button

But i don't get the idea that each row will have different constraints right?

[ChrisJohnNOAA]

@Anees02 The constraints are what is defined on the right side of the current UI. The columns titled "Optional Constraint #1" and "Optional Constraint #2". The goal of the change is to make it easy for users to see and control what rows have a constraint applied to them when the url is generated.

[Anees02]

@ChrisJohnNOAA

the plan i explained is that correct, if it is correct i will work on the plan

[ChrisJohnNOAA]

@Anees02 Yes, the plan sounds good.

[Anees02]

@ChrisJohnNOAA !
I don't understand the code at all, I have hands on experience in html, css and javascript.
I built java applications using spring and spring boot with react js as front end.

I code looks very vast and i don't know how much time it will take time to understand the codebase.