Upgrade to Astro v6, drop unused @astrojs/cloudflare, pin Node 22#311
Conversation
Deploying espresense with
|
| Latest commit: |
69bc628
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30e06a85.espresense.pages.dev |
| Branch Preview URL: | https://dependabot-npm-and-yarn-astr-bu7c.espresense.pages.dev |
|
@claude why does this fail? |
1 similar comment
|
@claude why does this fail? |
|
Claude finished @DTTerastar's task in 2m 16s —— View job Build Failure Analysis
Root Cause: Peer Dependency Mismatch
From "peerDependencies": {
"astro": "^6.0.0",
"wrangler": "^4.61.1"
}But the project currently has:
This is a major breaking change — What To DoThis PR should not be merged as-is. You have two options:
|
|
@claude Upgrade to Astro v6 |
|
Claude finished @DTTerastar's task in 6m 5s —— View job Upgrade to Astro v6 — Complete
What was changed
How this fixes the buildCloudflare Pages runs
Note on
|
|
Bump @astrojs/starlight @claude |
|
Claude finished @DTTerastar's task in 10m 47s —— View job Bumped @astrojs/starlight for Astro v6
What was done
WhyThe previous Astro v6 upgrade commit manually patched only the root section of
Deleting the lock file forces Cloudflare Pages to run a fresh
|
- Upgrade astro to ^6.0.0 and @astrojs/starlight to >=0.35.0 (peer-compatible) - Drop @astrojs/cloudflare: it was never wired into astro.config.mjs. This is a fully static site deployed to Cloudflare Pages with Pages Functions in functions/ that use Hono directly. Cloudflare adapter v13 also dropped Pages support, so keeping the dep would have been misleading. - Regenerate package-lock.json from a clean install (the previous one was inconsistent between the v5/v6 transition). - Pin Node 22 via .nvmrc so the Cloudflare Pages build uses a version compatible with Astro v6 (>=22.12 required). Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
5d36f2d to
69bc628
Compare
Summary
Started life as a dependabot bump of
@astrojs/cloudflarefrom 12 → 13, but the upgrade revealed that the adapter was never actually wired intoastro.config.mjs— so this PR removes it instead, and lands the related Astro v6 upgrade work cleanly.@astrojs/cloudflare: never used. The site is fully static (SSG, 33 HTML pages →dist/) deployed to Cloudflare Pages, with Pages Functions infunctions/that use Hono directly. Cloudflare adapter v13 also dropped Pages support in favor of Workers, so keeping the dep would have been actively misleading.Astro.glob, no<ViewTransitions>, no legacy content collections, no Astro endpoints, no i18n, content layer already in use, Starlightsocialalready on the new array form).package-lock.json: previous one was deleted in d14cb70 because it was inconsistent across the v5/v6 transition; CI was expected to regenerate it but a fresh local install also works..nvmrc: Astro v6 requires Node ≥22.12, and the Cloudflare Pages build environment had no Node version pinned anywhere (no.nvmrc, noengines, noNODE_VERSIONenv). Without this, the deploy would likely fail.Test plan
npm installsucceeds from a cleannode_modulesnpm run buildsucceeds (33 pages, sitemap, Pagefind search index all generated)functions/still work (releases + artifacts endpoints)🤖 Generated with Claude Code