Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical module/block definition #29

Open
KrisThielemans opened this issue Oct 5, 2024 · 2 comments
Open

Hierarchical module/block definition #29

KrisThielemans opened this issue Oct 5, 2024 · 2 comments
Assignees

Comments

@KrisThielemans
Copy link
Contributor

#22 introduced Modules of detector elements (single level). However, modules are generally hierarchical (blocks, mini-blocks, crystals etc, or even "units of modules"). This would be good to encode e.g. for dead-time.

@MaxTousss
Copy link

I can't find the exact PR, but this was used in the last NssMic, so this issue could be closed, right?

@KrisThielemans KrisThielemans self-assigned this Jan 17, 2025
@KrisThielemans
Copy link
Contributor Author

The issue is a question if we need/want to implement more levels than we currently have, so cannot close it quite yet.

However, in recent discussions, we have come to a tentative conclusion that we don't need to. A "PETSIRD module" would then be the smallest level that is needed (for dead-time, singles histograms etc). Higher levels can then be constructed "by hand" by just listing them via the rigid transformations. It's not clear to me yet if this breaks some stuff in the SGID concept for symmetries (but I don't think so), or if it implies a storage overhead.

So, I'll leave this up for a bit longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants