Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodes, nodey, and nodez #5

Open
djbower opened this issue Nov 1, 2019 · 1 comment
Open

nodes, nodey, and nodez #5

djbower opened this issue Nov 1, 2019 · 1 comment
Assignees

Comments

@djbower
Copy link
Collaborator

djbower commented Nov 1, 2019

The python preprocessing scripts use nodex, nodey, and nodez to define the number of elements and therefore the number of tracers. This is a legacy of the previous pyre version of CitcomS (no longer used). However, the C-code use different parameters to determine the nodes:

342 input_int("mgunitx",&(E->mesh.mgunitx),"1",m);
343 input_int("mgunitz",&(E->mesh.mgunitz),"1",m);
344 input_int("mgunity",&(E->mesh.mgunity),"1",m);
345
346 input_int("levels",&(E->mesh.levels),"1",m);
347
348 levmax = E->mesh.levels - 1;
349 E->mesh.nox = E->mesh.mgunitx * (int) pow(2.0,levmax) * E->parallel.nprocx + 1;
350 E->mesh.noy = E->mesh.mgunity * (int) pow(2.0,levmax) * E->parallel.nprocy + 1;
351 E->mesh.noz = E->mesh.mgunitz * (int) pow(2.0,levmax) * E->parallel.nprocz + 1;

This makes sense, since it forces the node counts to be compatible with the structure of a parallel multigrid solver. But it also means that the (potentially) user-specific nodes are not actually used! (which causes confusion).

It is not desirable to change the structure of the C-code since there are good reasons to do it this way. So we could either add a note in the assimilation documentation this is the case, or we could ask the preprocessing scripts to point this fact out.

@michaelchin michaelchin self-assigned this Dec 1, 2019
@michaelchin
Copy link

Force the equation nodex = 1 + nprocx + mgunitx + 2**(levels-1) to be satisfied in preprocessing python script.

f602784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants