Searching isn't working

[nyabinary]

On the high-tide app I'm getting errors trying to search things on the app, one of the app maintainers forwarded me to make an issue here since it's an issue with this apparently.
Nokse22/high-tide#123
for more screenshots, info, etc

[tehkillerbee]

The root cause of this issue appears to be related to the recent v2 playlist endpoint changes that were added in v0.8.4. Not quite fixed by #350 but it should at least help. Leaving this issue open until a proper fix is implemented.

[nyabinary]

Can we get a 8.4.1 release/hotfix for nixpkgs?

[tehkillerbee]

Yes, I will make a new release ASAP with the fixes implemented. But there might be some changes needed on high-tide's side as well wrt. pagination, after the recent v2 endpoint changes.

If you have a simple way to replicate the issue, I will try to test high-tide as well.

[blacklight]

@tehkillerbee it should be relatively simple, I have replicated by simply installing high-tide and then logging in with my account.

It breaks as soon as a playlist is loaded unless you apply #350.

After applying the workaround we still have the problem with pagination though (it should be sufficient to try and open a playlist with more than 50 items, only the first page is currently returned).

[nyabinary]

Yes, I will make a new release ASAP with the fixes implemented. But there might be some changes needed on high-tide's side as well wrt. pagination, after the recent v2 endpoint changes.

If you have a simple way to replicate the issue, I will try to test high-tide as well.

cc: @Nokse22 @nilathedragon

[Nokse22]

The issue is not just for searching, I have this issue even loading the home page. Opening High Tide with python-tidal 0.8.4 the home page can't be loaded:

Traceback (most recent call last):
  File "/usr/lib/python3.12/threading.py", line 1075, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.12/threading.py", line 1012, in run
    self._target(*self._args, **self._kwargs)
  File "/app/share/high-tide/high_tide/pages/home_page.py", line 42, in _th_load_page
    home = utils.session.home()
           ^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/tidalapi/session.py", line 1097, in home
    return self.page.get("pages/home")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/tidalapi/page.py", line 132, in get
    return self.parse(json_obj)
           ^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/tidalapi/page.py", line 112, in parse
    page_item = self.page_category.parse(row["modules"][0])
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/tidalapi/page.py", line 202, in parse
    return category.parse(json_obj)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/tidalapi/page.py", line 291, in parse
    self.items = self.request.map_json(json_obj[list_key], parse, session)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/tidalapi/request.py", line 252, in map_json
    return list(map(parse, items))
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/tidalapi/session.py", line 364, in parse_playlist
    return self.playlist().parse(obj["data"])
                                 ~~~^^^^^^^^
KeyError: 'data'

[tehkillerbee]

Yes, that issue should be fixed now (caused by returning non playlist types from that specific endpoint), resulting in the "data" field not existing. #350 partially fixes this, but the issue may still occur if a FOLDER type is parsed as a PLAYLIST.

You'll still need to fix pagination in your end, as you cannot fetch more than 50 objects (at a time) from the endpoint.
See #351 for more details and try to test if it works better for you. There are direct helper functions that can be used to fetch all playlists, albums, tracks etc. using pagination (multi threaded fetching)

[Nokse22]

Thank you, we will fix this on our end when the new version is released.