add back unrefs

Author: maxnut

.github/workflows/multi-platform.yml

@@ -15,17 +15,17 @@ jobs:
         - name: Windows
           os: windows-latest
 
-        - name: macOS
-          os: macos-latest
+        # - name: macOS
+        #   os: macos-latest
 
-        - name: Android32
-          os: ubuntu-latest
-          target: Android32
-          min-sdk: 24
+        # - name: Android32
+        #   os: ubuntu-latest
+        #   target: Android32
+        #   min-sdk: 24
 
-        - name: Android64
-          os: ubuntu-latest
-          target: Android64
+        # - name: Android64
+        #   os: ubuntu-latest
+        #   target: Android64
 
     name: ${{ matrix.config.name }}
     runs-on: ${{ matrix.config.os }}

src/recorder.cpp

@@ -129,23 +129,23 @@ bool Recorder::init(const RenderSettings& settings) {
         return false;
     }
 
-    m_convertedFrame = av_frame_alloc();
-    m_convertedFrame->format = m_codecContext->pix_fmt;
-    m_convertedFrame->width = m_codecContext->width;
-    m_convertedFrame->height = m_codecContext->height;
-    if(av_image_alloc(m_convertedFrame->data, m_convertedFrame->linesize, m_convertedFrame->width, m_convertedFrame->height, m_codecContext->pix_fmt, 32) < 0) {
-        geode::log::error("Could not allocate raw picture buffer.");
-        return false;
-    }
-
-    m_filteredFrame = av_frame_alloc();
-    m_filteredFrame->format = m_codecContext->pix_fmt;
-    m_filteredFrame->width = m_codecContext->width;
-    m_filteredFrame->height = m_codecContext->height;
-    if(av_image_alloc(m_filteredFrame->data, m_filteredFrame->linesize, m_filteredFrame->width, m_filteredFrame->height, m_codecContext->pix_fmt, 32) < 0) {
-        geode::log::error("Could not allocate raw picture buffer.");
-        return false;
-    }
+    // m_convertedFrame = av_frame_alloc();
+    // m_convertedFrame->format = m_codecContext->pix_fmt;
+    // m_convertedFrame->width = m_codecContext->width;
+    // m_convertedFrame->height = m_codecContext->height;
+    // if(av_image_alloc(m_convertedFrame->data, m_convertedFrame->linesize, m_convertedFrame->width, m_convertedFrame->height, m_codecContext->pix_fmt, 32) < 0) {
+    //     geode::log::error("Could not allocate raw picture buffer.");
+    //     return false;
+    // }
+
+    // m_filteredFrame = av_frame_alloc();
+    // m_filteredFrame->format = m_codecContext->pix_fmt;
+    // m_filteredFrame->width = m_codecContext->width;
+    // m_filteredFrame->height = m_codecContext->height;
+    // if(av_image_alloc(m_filteredFrame->data, m_filteredFrame->linesize, m_filteredFrame->width, m_filteredFrame->height, m_codecContext->pix_fmt, 32) < 0) {
+    //     geode::log::error("Could not allocate raw picture buffer.");
+    //     return false;
+    // }
 
     m_packet = new AVPacket();
 
@@ -255,6 +255,9 @@ bool Recorder::writeFrame(const std::vector<uint8_t>& frameData) {
         av_packet_unref(m_packet);
     }
 
+    av_frame_unref(m_convertedFrame);
+    av_frame_unref(m_filteredFrame);
+
     return true;
 }