feat(config): extend configuration with maxConnections and idleTimeout

Author: IvanChepurnyi

schema.json

@@ -7,6 +7,16 @@
       "$ref": "#/definitions/connection",
       "description": "MySQL connections settings"
     },
+    "maxConnections": {
+      "type": "integer",
+      "description": "Maximum number of open connection by tool",
+      "default": 50
+    },
+    "idleTimeout": {
+      "type": "integer",
+      "description": "Duration of keeping idle connection open",
+      "default": 60
+    },
     "includeTables": {
       "$ref": "#/definitions/tableConditions",
       "description": "List of tables to include from the database dump"

src/Configuration.php

@@ -24,6 +24,8 @@ private function __construct(
         public MysqlConfig $connection,
         public TableCondition $includeCondition,
         public TableCondition $excludeCondition,
+        public int $maxConnections,
+        public int $idleTimeout
     ) {
     }
 
@@ -95,20 +97,30 @@ function ($errors, $error) {
                 ),
             $includeCondition,
             $excludeCondition,
+            $data->maxConnections,
+            $data->idleTimeout
         );
     }
 
-    public static function fromMySQLConfig(MysqlConfig $config): self
+    public static function fromMySQLConfig(MysqlConfig $config, int $maxConnections = 50, int $idleTimeout = 60): self
     {
-        return new self($config, StaticTableCondition::alwaysTrue(), StaticTableCondition::alwaysFalse());
+        return new self(
+            $config,
+            StaticTableCondition::alwaysTrue(),
+            StaticTableCondition::alwaysFalse(),
+            $maxConnections,
+            $idleTimeout
+        );
     }
 
     public function withIncludeCondition(TableCondition $condition): self
     {
         return new self(
             $this->connection,
             $this->includeCondition->withCondition($condition),
-            $this->excludeCondition
+            $this->excludeCondition,
+            $this->maxConnections,
+            $this->idleTimeout,
         );
     }
 
@@ -117,7 +129,9 @@ public function withExcludeCondition(TableCondition $condition): self
         return new self(
             $this->connection,
             $this->includeCondition,
-            $this->excludeCondition->withCondition($condition)
+            $this->excludeCondition->withCondition($condition),
+            $this->maxConnections,
+            $this->idleTimeout,
         );
     }
 

tests/ConfigurationTest.php

@@ -9,7 +9,6 @@
 
 namespace EcomDev\MySQL2JSONL;
 
-
 use Amp\Mysql\MysqlConfig;
 use EcomDev\MySQL2JSONL\Condition\AndTableCondition;
 use EcomDev\MySQL2JSONL\Condition\TableNameCondition;
@@ -215,4 +214,30 @@ public function createsExcludeConditions()
             )
         );
     }
+
+    #[Test]
+    public function allowsSpecifyingMaxConnectionsAndIdleTimeout()
+    {
+        $this->assertEquals(
+            Configuration::fromMysqlConfig(
+                MysqlConfig::fromAuthority("db", "root", "", "magento")
+                    ->withSqlMode('')
+                    ->withCharset('utf8mb4', 'utf8mb4_unicode_ci'),
+                10,
+                5
+            ),
+            Configuration::fromJSON(
+                <<<JSON
+                {
+                  "connection": {
+                    "host": "db",
+                    "database": "magento"
+                  },
+                  "maxConnections": 10,
+                  "idleTimeout": 5
+                }
+                JSON
+            )
+        );
+    }
 }