Add ramp plugin amount type filtering

Author: samholmes

src/components/scenes/TradeCreateScene.tsx

@@ -12,7 +12,10 @@ import { COUNTRY_CODES, FIAT_COUNTRY } from '../../constants/CountryConstants'
 import { useHandler } from '../../hooks/useHandler'
 import { useRampPlugins } from '../../hooks/useRampPlugins'
 import { useRampQuotes } from '../../hooks/useRampQuotes'
-import { useSupportedPlugins } from '../../hooks/useSupportedPlugins'
+import {
+  type SupportedPluginResult,
+  useSupportedPlugins
+} from '../../hooks/useSupportedPlugins'
 import { useWatch } from '../../hooks/useWatch'
 import { lstrings } from '../../locales/strings'
 import type {
@@ -53,6 +56,47 @@ export interface TradeCreateParams {
 
 interface Props extends BuyTabSceneProps<'pluginListBuy'> {}
 
+// Helper function to determine which input types should be disabled
+interface AmountTypeSupport {
+  fiatInputDisabled: boolean
+  cryptoInputDisabled: boolean
+}
+
+function getAmountTypeSupport(
+  supportedPlugins: SupportedPluginResult[]
+): AmountTypeSupport {
+  if (supportedPlugins.length === 0) {
+    return { fiatInputDisabled: false, cryptoInputDisabled: false }
+  }
+
+  // Collect all supported amount types from all plugins
+  const allSupportedTypes = new Set<'fiat' | 'crypto'>()
+
+  for (const { supportResult } of supportedPlugins) {
+    if (supportResult.supportedAmountTypes != null) {
+      for (const type of supportResult.supportedAmountTypes) {
+        allSupportedTypes.add(type)
+      }
+    } else {
+      // If a plugin doesn't specify supported types, assume both are supported
+      allSupportedTypes.add('fiat')
+      allSupportedTypes.add('crypto')
+    }
+  }
+
+  // If all plugins only support fiat, disable crypto input
+  const onlyFiat =
+    allSupportedTypes.has('fiat') && !allSupportedTypes.has('crypto')
+  // If all plugins only support crypto, disable fiat input
+  const onlyCrypto =
+    allSupportedTypes.has('crypto') && !allSupportedTypes.has('fiat')
+
+  return {
+    fiatInputDisabled: onlyCrypto,
+    cryptoInputDisabled: onlyFiat
+  }
+}
+
 export const TradeCreateScene: React.FC<Props> = (props: Props) => {
   const { navigation, route } = props
   const { regionCode: initialRegionCode, forcedWalletResult } =
@@ -189,6 +233,10 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
     return info?.logoUrl ?? ''
   }, [selectedFiatCurrencyCode])
 
+  // Determine which input types should be disabled
+  const { fiatInputDisabled, cryptoInputDisabled } =
+    getAmountTypeSupport(supportedPlugins)
+
   // Create rampQuoteRequest based on current form state
   const rampQuoteRequest: RampQuoteRequest | null = React.useMemo(() => {
     if (
@@ -201,6 +249,14 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
       return null
     }
 
+    // Guard against creating request with disabled input type
+    if (
+      (lastUsedInput === 'fiat' && fiatInputDisabled) ||
+      (lastUsedInput === 'crypto' && cryptoInputDisabled)
+    ) {
+      return null
+    }
+
     return {
       wallet: selectedWallet,
       pluginId: selectedWallet.currencyInfo.pluginId,
@@ -224,7 +280,9 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
     selectedFiatCurrencyCode,
     lastUsedInput,
     countryCode,
-    stateProvinceCode
+    stateProvinceCode,
+    fiatInputDisabled,
+    cryptoInputDisabled
   ])
 
   // Fetch quotes using the custom hook
@@ -236,7 +294,7 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
   } = useRampQuotes({
     rampQuoteRequest,
     plugins: Object.fromEntries(
-      supportedPlugins.map(plugin => [plugin.pluginId, plugin])
+      supportedPlugins.map(result => [result.plugin.pluginId, result.plugin])
     )
   })
 
@@ -301,6 +359,9 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
 
   // Derived state for display values
   const displayFiatAmount = React.useMemo(() => {
+    // Don't show any value if fiat input is disabled
+    if (fiatInputDisabled) return ''
+
     if (isMaxAmount && bestQuote != null) {
       return bestQuote.fiatAmount
     }
@@ -312,9 +373,19 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
       // User entered crypto, convert to fiat only if we have a quote
       return convertCryptoToFiat(userInput)
     }
-  }, [userInput, lastUsedInput, convertCryptoToFiat, isMaxAmount, bestQuote])
+  }, [
+    userInput,
+    lastUsedInput,
+    convertCryptoToFiat,
+    isMaxAmount,
+    bestQuote,
+    fiatInputDisabled
+  ])
 
   const displayCryptoAmount = React.useMemo(() => {
+    // Don't show any value if crypto input is disabled
+    if (cryptoInputDisabled) return ''
+
     if (isMaxAmount && bestQuote != null) {
       return bestQuote.cryptoAmount
     }
@@ -326,7 +397,14 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
       // User entered fiat, convert to crypto only if we have a quote
       return convertFiatToCrypto(userInput)
     }
-  }, [userInput, lastUsedInput, convertFiatToCrypto, isMaxAmount, bestQuote])
+  }, [
+    userInput,
+    lastUsedInput,
+    convertFiatToCrypto,
+    isMaxAmount,
+    bestQuote,
+    cryptoInputDisabled
+  ])
 
   //
   // Handlers
@@ -546,6 +624,7 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
                   keyboardType="decimal-pad"
                   numeric
                   showSpinner={isFetchingQuotes && lastUsedInput === 'crypto'}
+                  disabled={fiatInputDisabled}
                 />
               </InputContainer>
             </InputRow>
@@ -573,6 +652,7 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
                   keyboardType="decimal-pad"
                   numeric
                   showSpinner={isFetchingQuotes && lastUsedInput === 'fiat'}
+                  disabled={cryptoInputDisabled}
                 />
                 {/* MAX Button */}
                 <MaxButton onPress={handleMaxPress}>
@@ -656,7 +736,9 @@ export const TradeCreateScene: React.FC<Props> = (props: Props) => {
           isCheckingSupport ||
           supportedPlugins.length === 0 ||
           isLoadingQuotes ||
-          sortedQuotes.length === 0
+          sortedQuotes.length === 0 ||
+          (lastUsedInput === 'fiat' && fiatInputDisabled) ||
+          (lastUsedInput === 'crypto' && cryptoInputDisabled)
         }
       />
     </>

src/components/scenes/TradeOptionSelectScene.tsx

@@ -77,7 +77,7 @@ export const TradeOptionSelectScene: React.FC<Props> = (props: Props) => {
 
   // Use supported plugins
   const pluginsToUse = Object.fromEntries(
-    supportedPlugins.map(plugin => [plugin.pluginId, plugin])
+    supportedPlugins.map(result => [result.plugin.pluginId, result.plugin])
   )
 
   // Use the ramp quotes hook

src/hooks/useSupportedPlugins.ts

@@ -5,7 +5,8 @@ import * as React from 'react'
 import type { FiatPluginRegionCode } from '../plugins/gui/fiatPluginTypes'
 import type {
   RampCheckSupportRequest,
-  RampPlugin
+  RampPlugin,
+  RampSupportResult
 } from '../plugins/ramps/rampPluginTypes'
 
 interface UseSupportedPluginsParams {
@@ -21,8 +22,13 @@ interface UseSupportedPluginsParams {
   direction?: 'buy' | 'sell'
 }
 
+export interface SupportedPluginResult {
+  plugin: RampPlugin
+  supportResult: RampSupportResult
+}
+
 interface UseSupportedPluginsResult {
-  supportedPlugins: RampPlugin[]
+  supportedPlugins: SupportedPluginResult[]
   isLoading: boolean
   error: Error | null
 }
@@ -68,7 +74,7 @@ export const useSupportedPlugins = ({
     data: supportedPlugins = [],
     isLoading,
     error
-  } = useQuery<RampPlugin[]>({
+  } = useQuery<SupportedPluginResult[]>({
     queryKey,
     queryFn: async () => {
       // Early return if required params are missing
@@ -98,10 +104,10 @@ export const useSupportedPlugins = ({
       const supportChecks = await Promise.all(
         Object.values(plugins).map(async plugin => {
           try {
-            const result = await plugin.checkSupport(checkSupportRequest)
+            const supportResult = await plugin.checkSupport(checkSupportRequest)
             return {
               plugin,
-              supported: result.supported
+              supportResult
             }
           } catch (error) {
             console.warn(
@@ -110,16 +116,14 @@ export const useSupportedPlugins = ({
             )
             return {
               plugin,
-              supported: false
+              supportResult: { supported: false }
             }
           }
         })
       )
 
       // Filter only supported plugins
-      return supportChecks
-        .filter(check => check.supported)
-        .map(check => check.plugin)
+      return supportChecks.filter(check => check.supportResult.supported)
     },
     enabled:
       selectedWallet != null &&

src/plugins/ramps/banxa/banxaRampPlugin.ts

@@ -844,7 +844,10 @@ export const banxaRampPlugin: RampPluginFactory = (
         return { supported: false }
       }
 
-      return { supported: true }
+      return {
+        supported: true,
+        supportedAmountTypes: ['fiat', 'crypto']
+      }
     },
 
     fetchQuote: async (

src/plugins/ramps/bity/bityRampPlugin.ts

@@ -666,7 +666,10 @@ export const bityRampPlugin = (pluginConfig: RampPluginConfig): RampPlugin => {
       }
 
       // All checks passed
-      return { supported: true }
+      return {
+        supported: true,
+        supportedAmountTypes: ['fiat', 'crypto']
+      }
     },
 
     fetchQuote: async (

src/plugins/ramps/paybis/paybisRampPlugin.ts

@@ -707,7 +707,10 @@ export const paybisRampPlugin: RampPluginFactory = (
       }
 
       // If we get here, it's supported
-      return { supported: true }
+      return {
+        supported: true,
+        supportedAmountTypes: ['fiat', 'crypto']
+      }
     },
 
     fetchQuote: async (

src/plugins/ramps/rampPluginTypes.ts

@@ -31,6 +31,8 @@ export interface RampCheckSupportRequest {
 
 export interface RampSupportResult {
   supported: boolean
+  // Indicates which amount types are supported by this plugin
+  supportedAmountTypes?: Array<'fiat' | 'crypto'>
 }
 
 export interface RampQuoteRequest {

src/plugins/ramps/revolut/revolutRampPlugin.ts

@@ -163,7 +163,10 @@ export const revolutRampPlugin: RampPluginFactory = (
         assetMap
       })
 
-      return { supported: assetsSupported }
+      return {
+        supported: assetsSupported,
+        supportedAmountTypes: assetsSupported ? ['fiat'] : undefined
+      }
     },
 
     fetchQuote: async (
@@ -188,13 +191,7 @@ export const revolutRampPlugin: RampPluginFactory = (
         return []
       }
 
-      // Only support fiat amount type (Revolut requires fiat-based quotes)
-      if (request.amountType !== 'fiat') {
-        throw new FiatProviderError({
-          providerId: pluginId,
-          errorType: 'amountTypeUnsupported'
-        })
-      }
+      // Amount type check is now handled in checkSupport phase
 
       // Fetch provider configuration (will use cache if valid)
       const config = await fetchProviderConfig()

src/plugins/ramps/simplex/simplexRampPlugin.ts

@@ -536,7 +536,10 @@ export const simplexRampPlugin: RampPluginFactory = (
       }
 
       // All validations passed
-      return { supported: true }
+      return {
+        supported: true,
+        supportedAmountTypes: ['fiat', 'crypto']
+      }
     },
 
     fetchQuote: async (