Skip to content

Conversation

@swansontec
Copy link
Contributor

@swansontec swansontec commented Oct 8, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

@swansontec swansontec force-pushed the william/upgrade-build branch 2 times, most recently from 2965ddd to f4a383a Compare October 8, 2025 18:35
@swansontec
Copy link
Contributor Author

swansontec commented Oct 8, 2025

The second commit in this PR comes from #57, aside from a few changes.

  • Instead of hacking metro.config.js to grab sources from the parent folder, I created an update-tests.sh script to copy the parent folder into node_modules, since this works for the native code as well.
  • I compared everything with the rn-diff-purge tool, and copied over a few more upstream React Native files that were missed.

@swansontec
Copy link
Contributor Author

The final commit is basically a copy-paste from https://github.com/EdgeApp/react-native-zano/, replacing the Zano library with the libsecp256k1 library (but it's still CMake-based).

This gives us all the nice goodies, like hiding internal symbols from the linker. We no longer ship any C++ code on Android - it's all bundled in the .so.

@gre-ledger
Copy link
Contributor

👋 how are you? Do you know when we can expect to have the new version released? Happy to test any beta version too.

@swansontec
Copy link
Contributor Author

I assigned a reviewer a few weeks ago, but they haven't gotten around to it. I'll reassign the task to somebody else.

This is based on our react-native-zano repo, rather than the old airbitz-core repo.
@swansontec swansontec force-pushed the william/upgrade-build branch from f4a383a to a1ba3d9 Compare October 27, 2025 19:04
@swansontec swansontec merged commit ebe4fff into master Oct 27, 2025
1 check passed
@swansontec swansontec deleted the william/upgrade-build branch October 27, 2025 19:10
@swansontec
Copy link
Contributor Author

swansontec commented Oct 27, 2025

@gre-ledger Published as 3.0.0. Sorry it took so long. Let me know if it works for you, or if we need any additional fixes.

@gre-ledger
Copy link
Contributor

@swansontec thanks a lot . it works well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants