Skip to content

feat(pipe-tubular-FEM): add specialized function for creating Tubular cable parts#24

Merged
amaurigmartins merged 1 commit intoElecta-Git:mainfrom
MohamedNumair:feature/pipe-type-support
Mar 19, 2026
Merged

feat(pipe-tubular-FEM): add specialized function for creating Tubular cable parts#24
amaurigmartins merged 1 commit intoElecta-Git:mainfrom
MohamedNumair:feature/pipe-type-support

Conversation

@MohamedNumair
Copy link
Copy Markdown
Contributor

Just added distinct geometry for tubular conductor for FEM geometry in case of being used as a pipe/sheath/armour.
Previously, the material inside the Tubular was overlapping with the existing conductors

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 76.59574% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.23%. Comparing base (7915047) to head (b4155ea).
⚠️ Report is 255 commits behind head on main.

Files with missing lines Patch % Lines
src/engine/fem/cable.jl 76.59% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   52.08%   52.23%   +0.15%     
==========================================
  Files          94       94              
  Lines        6854     6901      +47     
==========================================
+ Hits         3570     3605      +35     
- Misses       3284     3296      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amaurigmartins amaurigmartins merged commit 8aea3bc into Electa-Git:main Mar 19, 2026
5 checks passed
@amaurigmartins amaurigmartins deleted the feature/pipe-type-support branch March 19, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants