Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too tight tolerance in Common Trig Functions testset #588

Open
giordano opened this issue Jan 21, 2025 · 3 comments
Open

Too tight tolerance in Common Trig Functions testset #588

giordano opened this issue Jan 21, 2025 · 3 comments

Comments

@giordano
Copy link
Member

As reported in #543 (comment): Julia 1.11 - core - ubuntu-20.04 - x64 - packaged libReactant - assertions=false

fn = tanpi: Test Failed at /home/runner/work/Reactant.jl/Reactant.jl/test/basic.jl:1012
  Expression: #= /home/runner/work/Reactant.jl/Reactant.jl/test/basic.jl:1012 =# @jit(fn.(x_ra)) ≈ fn.(x)
   Evaluated: ConcreteRArray{Float32, 2}(Float32[-0.21030955 6.786836 … 25.12034 -14.385436; -0.19476584 1.6611387 … -0.19030015 14.128226; -19.919302 4.171895 … 0.16302171 2.0547147; 0.40969867 0.09946294 … 1.0452943 1.3147937]) ≈ Float32[-0.21030961 6.7868366 … 25.120296 -14.385441; -0.19476582 1.6611385 … -0.19030032 14.128206; -19.919342 4.1718936 … 0.16302171 2.0547144; 0.40969867 0.099462934 … 1.0452943 1.3147937]
@giordano
Copy link
Member Author

I may be wrong, but I haven't seen error for a few days 🤔

@giordano
Copy link
Member Author

giordano commented Feb 5, 2025

@wsmoses
Copy link
Member

wsmoses commented Feb 5, 2025

I feel like we should not use rand as the way to resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants