Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a German Localisation Branch #42

Open
NeoEx0 opened this issue Mar 6, 2025 · 3 comments
Open

Adding a German Localisation Branch #42

NeoEx0 opened this issue Mar 6, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@NeoEx0
Copy link
Contributor

NeoEx0 commented Mar 6, 2025

Is your feature request related to a problem? Please describe.
At the current moment, there is the necessary directory structure, tag and files for a german localisation, but everything in those files (atleast the once i checked) is still in english

Describe the solution you'd like
As such i Request the Opening of a German Localisation branch so the translation efforts can beginn without impacting the main branch.

Describe alternatives you've considered
Although it would be possible to do the translation on the main branch, it would lead to having only a partial translation in the mod for quit a while.

Additional context
For an example of a still untranslated localisation file, see
EoaNB/localisation/german/Finland_l_german.yml

@NeoEx0 NeoEx0 added the enhancement New feature or request label Mar 6, 2025
@Mtio26
Copy link
Collaborator

Mtio26 commented Mar 6, 2025

I do not agree on this one,
The branches tend to become outdated with their content and well whilst translating basic core files won’t cause issues translating anything like a nations loc file is wasted time as it probably got changed on main or any other branch.
I actually am planning to merge the other translation branches into main once they achieve a minimum amount of translated content. Only reason they got own branches is for the mod to not have 157 languages in code with only one actually getting work done.
And these files may be in English now but they still can and will get translated just on main cause partial translation doesn’t change much if the other option is no translation at all.

Ps The best way to avoid partial translation is to fully translate all, got any interest in helping?

@NeoEx0
Copy link
Contributor Author

NeoEx0 commented Mar 6, 2025

If that's the case, i want to ask, if its ok for me to make a Fork and translate one or two files(would make a pull request once an entire file is finished)?

@Mtio26
Copy link
Collaborator

Mtio26 commented Mar 6, 2025

That’d be very nice, tho I’d prefer you’d join the team over there in discord and make it easier for the other translators due to the organization that gets done after translating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants