Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Uk amazon #43

Open
SamShanks1 opened this issue Dec 2, 2020 · 8 comments
Open

Not working with Uk amazon #43

SamShanks1 opened this issue Dec 2, 2020 · 8 comments

Comments

@SamShanks1
Copy link

When using this with uk amazon it says:
unable to convert "£140.45" to float... caught exception: could not convert string to float: '£140.45'
however it works with US amazin

@EricJMarti
Copy link
Owner

Can you try manually editing the Dockerfile, changing these three lines:

ENV LC_ALL en_US.UTF-8
ENV LANG en_US.UTF-8
ENV LANGUAGE en_US.UTF-8

to:

ENV LC_ALL en_GB.UTF-8
ENV LANG en_GB.UTF-8
ENV LANGUAGE en_GB.UTF-8

@SamShanks1
Copy link
Author

Works now
Thank you <3

@SamShanks1
Copy link
Author

One more thing the UK site ebuyer uses add-to-basket instead of add-to-cart so it thinks its out of stock is it possible to add it so it checks for that as well

@EricJMarti
Copy link
Owner

Just checked in this change: a90683d

Can you pull in the latest code, rebuild the docker image, and try again?

@Burito55
Copy link
Contributor

Burito55 commented Dec 3, 2020

Is it possible to fix Amazon SG as well? It uses S$ which messed up the code

@jamesearls
Copy link

I am also having this issue however, editing the Dockerfile isn't fixing it for me.

@EricJMarti
Copy link
Owner

Can you try again with the latest image? I recently committed a change that was intended to ignore currency symbols.

@jamesearls
Copy link

jamesearls commented Dec 20, 2020

@EricJMarti I have pulled down the recent changes and I am getting SCRAPE FAILED on amazon.co.uk. The Float issue is fixed.
(edit: fixed misleading wording & grammar)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants