Jb/demo #16
Merged
Jb/demo #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
Ancient123 and
imabdulbasit
and removed request for
Ancient123
Ancient123
reviewed
Nov 6, 2025
demo/docker-compose.yaml
Outdated
| @@ -0,0 +1,62 @@ | |||
| services: | |||
| l1: | |||
| image: ghcr.io/espressosystems/geth-l1:main | |||
Member
There was a problem hiding this comment.
Dumb question, but why do this instead of using the geth-l1-staging that has the genesis baked in?
https://github.com/EspressoSystems/espresso-geth/blob/main/config/genesis-staging.json
https://github.com/EspressoSystems/espresso-geth/pkgs/container/geth-l1-staging
Member
Author
There was a problem hiding this comment.
I did not know that was a thing.
Ancient123
reviewed
Nov 6, 2025
| tags: ghcr.io/espressosystems/staking-ui-service:latest | ||
| inputs: ghcr.io/espressosystems/staking-ui-service@${{ needs.build-amd.outputs.digest }},ghcr.io/espressosystems/staking-ui-service@${{ needs.build-arm.outputs.digest }} | ||
| push: ${{ github.event_name != 'pull_request' }} | ||
| test-demo: |
Member
There was a problem hiding this comment.
This feels like a build step we should put a timing bound on. Something like 2x the expected runtime of the workflow
Ancient123
reviewed
Nov 6, 2025
| @@ -0,0 +1,42 @@ | |||
| name: Test Demo | |||
Member
There was a problem hiding this comment.
Same thing here. Demos just tend to have lots of places they could hang and have unbounded runtimes in my experience.
Ancient123
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.