chore: Move two-pass format check into AbstractFFmpegOutputBuilder

Author: Euklios

src/main/java/net/bramp/ffmpeg/builder/AbstractFFmpegOutputBuilder.java

@@ -255,6 +255,7 @@ public EncodingOptions buildOptions() {
   @Override
   protected List<String> build(int pass) {
     Preconditions.checkState(parent != null, "Can not build without parent being set");
+
     return build(parent, pass);
   }
 
@@ -273,7 +274,10 @@ protected List<String> build(FFmpegBuilder parent, int pass) {
       checkArgument(
           targetSize != 0 || video_bit_rate != 0,
           "Target size, or video bitrate must be specified when using two-pass");
+
+      checkArgument(format != null, "Format must be specified when using two-pass");
     }
+
     if (targetSize > 0) {
       checkState(parent.inputs.size() == 1, "Target size does not support multiple inputs");
 

src/main/java/net/bramp/ffmpeg/builder/AbstractFFmpegStreamBuilder.java

@@ -55,7 +55,7 @@
  */
 public abstract class AbstractFFmpegStreamBuilder<T extends AbstractFFmpegStreamBuilder<T>> {
 
-  private static final String DEVNULL = SystemUtils.IS_OS_WINDOWS ? "NUL" : "/dev/null";
+  protected static final String DEVNULL = SystemUtils.IS_OS_WINDOWS ? "NUL" : "/dev/null";
 
   final FFmpegBuilder parent;
 
@@ -551,11 +551,6 @@ protected List<String> build(int pass) {
   protected List<String> build(FFmpegBuilder parent, int pass) {
     checkNotNull(parent);
 
-    if (pass > 0) {
-      // TODO Write a test for this:
-      checkArgument(format != null, "Format must be specified when using two-pass");
-    }
-
     ImmutableList.Builder<String> args = new ImmutableList.Builder<>();
 
     addGlobalFlags(parent, args);