-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors when resuming from sleep #178
Comments
Hi @notthatwillsmith, I was able to reproduce this and I'm currently working on a fix. |
@Rem0o Do you think Fan Control should close plugins on Suspend (and reload them on Resume) in lieu of plugins needing to handle |
It does already actually, but you can't "stop" the suspend process to allow code to run until completion, it will do the best it can before the suspend comes into effet, and whatever was not done will be executed on resume. Fun fact, handling sleep in FanControl is the single hardest and most complicated thing in the software to handle. The most reliable way to deal with this has been to do everything on resume (full refresh, so close + init). |
Haha - I don't doubt that. Thanks! |
The plugin's behavior has been improved when sleeping/resuming as of v1.7.0-beta.5. However, some devices will still need their USB connections cycled to recover properly as that is not yet handled by the plugin. A workaround is provided in #205. |
I'm getting errors on resume from suspend with the CorsairLink plugin pulling pump speed and liquid temperature from my AIO. The AIO is the iCUE Link H150i and all the USB devices between the AIO and the PCI Express bus have the ability to go to sleep to save power disabled in Device Manager.
I'm running v194 of Fan Control and 1.6.0 of the CorsairLink plugin.
I've attached logs below, but the error is :
If I refresh sensor detection, Fan Control recovers and works fine, but I often have to reattach the sources that are on the AIO to the appropriate cards on Fan Control. Logs are attached below.
log.zip
The text was updated successfully, but these errors were encountered: