move getValenceOrbitalsByElement to method data context mixin

Author: pranabdas

src/context/mixins/MethodDataContextMixin.js

@@ -58,6 +58,19 @@ export function methodDataContextMixin(item) {
                 };
             });
         },
+
+        getValenceOrbitalsByElement(element) {
+            const valenceOrbitals = this.valenceOrbitals || [];
+            let orbitals = [];
+            valenceOrbitals.every((entry) => {
+                if (entry.element === element) {
+                    orbitals = entry?.valenceOrbitals || [];
+                }
+                return entry.element !== element; // break when first match is found
+            });
+
+            return orbitals;
+        },
     };
 
     Object.defineProperties(item, Object.getOwnPropertyDescriptors(properties));

src/context/providers/HubbardUContextProvider.js

@@ -75,23 +75,17 @@ export class HubbardUContextProvider extends JSONSchemaFormDataProvider {
         };
     }
 
-    getValenceOrbitalsByElement = (element) => {
-        const valenceOrbitals = this.valenceOrbitals || [];
-        let orbitals = [];
-        valenceOrbitals.every((item) => {
-            if (item.element === element) {
-                orbitals = item?.valenceOrbitals || [];
-            }
-            return item.element !== element; // break when first match is found
-        });
-
-        return Utils.array.sortArrayByOrder(orbitals, this.orbitalListByStability);
+    sortedValanceOrbitalsByElement = (element) => {
+        return Utils.array.sortArrayByOrder(
+            this.getValenceOrbitalsByElement(element),
+            this.orbitalListByStability,
+        );
     };
 
     orbitalDependencyArray = (elementList, atomicSpecies, atomicOrbital) => {
         return {
             oneOf: elementList.map((elementWithLabel) => {
-                const orbitals = this.getValenceOrbitalsByElement(
+                const orbitals = this.sortedValanceOrbitalsByElement(
                     Made.Basis.stripLabelToGetElementSymbol(elementWithLabel),
                 );
                 return {