Skip to content

Commit d6190de

Browse files
MelvinBotsituchan
andcommitted
Remove redundant loading-indicator comments per review
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
1 parent c39bce0 commit d6190de

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

src/pages/iou/request/step/withFullTransactionOrNotFound.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,6 @@ function WithFullTransactionOrNotFoundImpl<TProps extends WithFullTransactionOrN
115115
context: 'withFullTransactionOrNotFound',
116116
isLoadingTransaction,
117117
};
118-
// When embedded (shouldHideHeader), the parent page's header stays visible, so per UI-1 use ActivityIndicator
119-
// (the user can still go back). Standalone RHP routes render this before their own header, so keep the fullscreen loader.
120118
return shouldHideHeader ? (
121119
<View style={[styles.flex1, styles.fullScreenLoading]}>
122120
<ActivityIndicator
@@ -125,7 +123,6 @@ function WithFullTransactionOrNotFoundImpl<TProps extends WithFullTransactionOrN
125123
/>
126124
</View>
127125
) : (
128-
// Standalone RHP route: no navigation chrome renders behind this, so per UI-1 enable the emergency "Go Back" button in case the load hangs.
129126
<FullScreenLoadingIndicator
130127
reasonAttributes={reasonAttributes}
131128
shouldUseGoBackButton

0 commit comments

Comments
 (0)