Merge pull request #98299 from callstack-internal/perf/onyx-deepequal-probe

Hoist the active policy subscription out of Search rows

Author: mountiny

src/components/ActivePolicyProvider.tsx

@@ -0,0 +1,35 @@
+import useOnyx from '@hooks/useOnyx';
+
+import CONST from '@src/CONST';
+import ONYXKEYS from '@src/ONYXKEYS';
+import type {Policy} from '@src/types/onyx';
+import type ChildrenProps from '@src/types/utils/ChildrenProps';
+
+import type {OnyxEntry} from 'react-native-onyx';
+
+import React, {createContext, useContext} from 'react';
+
+type ActivePolicyContextValue = {
+    activePolicyID: string | undefined;
+    activePolicy: OnyxEntry<Policy>;
+};
+
+const ActivePolicyContext = createContext<ActivePolicyContextValue>({activePolicyID: undefined, activePolicy: undefined});
+
+const activePolicySelector = (policy: OnyxEntry<Policy>) => (policy?.type !== CONST.POLICY.TYPE.PERSONAL ? policy : undefined);
+
+function ActivePolicyProvider({children}: ChildrenProps) {
+    const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID);
+    const [activePolicy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID}`, {
+        selector: activePolicySelector,
+    });
+
+    return <ActivePolicyContext.Provider value={{activePolicyID, activePolicy}}>{children}</ActivePolicyContext.Provider>;
+}
+
+function useActivePolicyContext() {
+    return useContext(ActivePolicyContext);
+}
+
+export default ActivePolicyProvider;
+export {useActivePolicyContext};

src/components/OnyxListItemProvider.tsx

@@ -2,6 +2,7 @@ import ONYXKEYS from '@src/ONYXKEYS';
 
 import React from 'react';
 
+import ActivePolicyProvider from './ActivePolicyProvider';
 import ComposeProviders from './ComposeProviders';
 import createOnyxContext from './createOnyxContext';
 
@@ -42,6 +43,7 @@ function OnyxListItemProvider(props: OnyxListItemProviderProps) {
                 CardListProvider,
                 WorkspaceCardListProvider,
                 OnboardingValuesProvider,
+                ActivePolicyProvider,
             ]}
         >
             {props.children}

src/hooks/usePolicyForMovingExpenses.ts

@@ -1,3 +1,4 @@
+import {useActivePolicyContext} from '@components/ActivePolicyProvider';
 import {useSession} from '@components/OnyxListItemProvider';
 
 import {canSubmitPerDiemExpenseFromWorkspace, isGroupPolicy, isPolicyMemberWithoutPendingDelete, isTimeTrackingEnabled} from '@libs/PolicyUtils';
@@ -9,8 +10,6 @@ import {isEmptyObject} from '@src/types/utils/EmptyObject';
 
 import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
 
-import {activePolicySelector} from '@selectors/Policy';
-
 import useOnyx from './useOnyx';
 
 // TODO: temporary util - if we don't have employeeList object we don't check for the pending delete
@@ -90,10 +89,7 @@ type PolicyForMovingExpenses = {
 };
 
 function usePolicyForMovingExpenses(isPerDiemRequest?: boolean, isTimeRequest?: boolean, expensePolicyID?: string, isUnreportedManagedCardTransaction?: boolean): PolicyForMovingExpenses {
-    const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID);
-    const [activePolicy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID}`, {
-        selector: activePolicySelector,
-    });
+    const {activePolicyID, activePolicy} = useActivePolicyContext();
 
     const session = useSession();
     const login = session?.email ?? '';

src/selectors/Policy.ts

@@ -30,8 +30,6 @@ type ReusablePolicyConnectionName =
     | typeof CONST.POLICY.CONNECTIONS.NAME.RILLET
     | typeof CONST.POLICY.CONNECTIONS.NAME.DUALENTRY;
 
-const activePolicySelector = (policy: OnyxEntry<Policy>) => (policy?.type !== CONST.POLICY.TYPE.PERSONAL ? policy : undefined);
-
 const ownerPoliciesSelector = (policies: OnyxCollection<Policy>, currentUserAccountID: number) => getOwnedPaidPolicies(policies, currentUserAccountID);
 
 type OwnedPaidPoliciesCounts = {
@@ -393,7 +391,6 @@ const createAdminPoliciesSelector =
 
 export type {PolicySelector};
 export {
-    activePolicySelector,
     createAllPolicyReportFieldsSelector,
     ownerPoliciesSelector,
     createOwnedPaidPoliciesCountsSelector,