This issue tracks the NAB / follow-up items identified during review of Expensify/App#90777 (Add currency selector to Search footer total spend). These were intentionally deferred from that PR to keep its scope manageable.
Follow-ups
-
Loading indicator flashes momentarily — metadata briefly sets isLoading to true, causing the footer loading indicator to appear for a moment. Fixing it cleanly requires separate branching logic and was deferred to avoid regressions in an already-large PR. (comment)
-
Add a Recents section to the currency picker — the currency list should include a Recents section, ideally applied to the Spend page filter currency picker as well. (comment, confirmed as follow-up in this reply)
-
Currency selector popup flickers when opened for the first time after selecting rows. (comment)
-
Currency selector popup opens with the keyboard already open on Native and mWeb. (comment)
-
State updated during render in SearchSelectionFooter — move the state change into a useEffect, or add a comment explaining why it must happen during render. See src/components/Search/SearchSelectionFooter.tsx:84. (comment)
-
Footer currency dropdown arrow direction — since the button sits in the screen footer and the selector opens upward, consider showing an up arrow when closed and switching to a down arrow when opened. See src/components/Search/SearchPageFooter.tsx:86. (comment)
Created at the request of c3024 to track follow-ups from Expensify/App#90777.
This issue tracks the NAB / follow-up items identified during review of Expensify/App#90777 (Add currency selector to Search footer total spend). These were intentionally deferred from that PR to keep its scope manageable.
Follow-ups
Loading indicator flashes momentarily —
metadatabriefly setsisLoadingtotrue, causing the footer loading indicator to appear for a moment. Fixing it cleanly requires separate branching logic and was deferred to avoid regressions in an already-large PR. (comment)Add a Recents section to the currency picker — the currency list should include a Recents section, ideally applied to the Spend page filter currency picker as well. (comment, confirmed as follow-up in this reply)
Currency selector popup flickers when opened for the first time after selecting rows. (comment)
Currency selector popup opens with the keyboard already open on Native and mWeb. (comment)
State updated during render in
SearchSelectionFooter— move the state change into auseEffect, or add a comment explaining why it must happen during render. Seesrc/components/Search/SearchSelectionFooter.tsx:84. (comment)Footer currency dropdown arrow direction — since the button sits in the screen footer and the selector opens upward, consider showing an up arrow when closed and switching to a down arrow when opened. See
src/components/Search/SearchPageFooter.tsx:86. (comment)Created at the request of
c3024to track follow-ups from Expensify/App#90777.