[Split #94595] Batch E - Remove useOnyx deps from MR views and confirmation

[mountiny]

Sub-issue of #94595.
Source plan: fabioh8010 comment.

Goal

Remove the deprecated 3rd dependencies argument from Money Request views, confirmation, and expense flows.

Scope (8 files)

• ReportActionItem/MoneyRequestView (RESTRUCTURE)
• ReportActionItem/MoneyRequestReceiptView
• MoneyRequestConfirmationList/sections/ReportField
• MoneyRequestConfirmationList/sections/InvoiceSenderField (RESTRUCTURE)
• pages/AddExistingExpense
• pages/iou/SplitExpenseEditPage
• pages/RejectExpenseReportPage
• KYCWall/BaseKYCWall (USECALLBACK — React Compiler bailout)

Change types

RESTRUCTURE (MoneyRequestView, InvoiceSenderField); USECALLBACK (BaseKYCWall).

Risk

Highest-touch UI batch.

Dependencies

Blocked by PR 1 (ESLint guard) merged.

Tests / QA

Open MoneyRequestView (edit fields), receipt view, split-expense edit, reject-expense page, invoice sender field, report field selector; verify amounts/participants/policies. Confirm BaseKYCWall stays compiler-bailout.

Acceptance criteria

1. npm run fmt on changed files
2. npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
3. npm run typecheck stays green
4. npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
5. Relevant npm run test for touched areas
6. Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

@hoangzinh Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@hoangzinh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[hoangzinh]

We will go back on this issue soon #94595 (comment)