[Due for payment 2026-07-29] [Perf] De-duplicate Onyx subscriptions in report preview action buttons via shared hooks

[cristipaval]

Problem

SubmitActionButton, ApproveActionButton, and PayActionButton each repeat the
same work on their own. Every one of them runs the same Onyx subscription block,
does the same transaction derivation, and defines its own confirmApproval handler.

This is duplicated logic across three components. It also means the same Onyx data
is subscribed to three times, which adds re-render work that we don't need.

Goal

• Move the shared logic into three hooks:
  • useReportPreviewActionButtonData
  • useReportPreviewFilteredTransactions
  • useConfirmApproveReportAction
• Update the three sub-buttons to use these hooks instead of repeating the code.
• No behavior change. The buttons should look and work exactly as before.

Related

• Parent: [Due for payment 2026-07-14][$250] Perf/decompose money request report preview #94603
• Follows the refactor in: [Due for payment 2026-07-23] [Perf] Refactor ReportPreviewActionButton to consume MoneyRequestReportPreviewProvider #95366
• Provider introduced in: [NOQA] perf: add MoneyRequestReportPreview layout components #94681

Issue Owner

Current Issue Owner: @linhvovan29546

[OlimpiaZurek]

Update:

• Fixed the conflicts on the PR, it's ready for review. @linhvovan29546 Can you take a look if you have a chance? Thanks!

[linhvovan29546]

Update:

• Fixed the conflicts on the PR, it's ready for review. @linhvovan29546 Can you take a look if you have a chance? Thanks!

I'll complete the review tomorrow. Since the main PR is still in staging, I'm waiting for it to be deployed to production.

[OlimpiaZurek]

Update:

• all comments on the PR addressed, it's already approved

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor: Extract shared hooks for report preview action buttons #95941

If no regressions arise, payment will be issued on 2026-07-29. 🎊

For reference, here are some details about the assignees on this issue:

• @OlimpiaZurek does not require payment (Contractor)
• @linhvovan29546 requires payment through NewDot Manual Requests