Add bank account page reopens after payments admin changes bank account and returns twice

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.41-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #96241
Email or phone of affected tester (no customers): applausetester+jx90nc0c@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Create a Control workspace.
• Workspace has business bank account.
• Owner invites User B to workspace as payments admin.

1. Go to staging.new.expensify.com
2. [Owner] Go to Account > Wallet.
3. [Owner] Click 3-dot menu on the bank account > Share.
4. [Owner] Select User B > Share.
5. [User B] Go to invited workspace settings > Workflows.
6. [User B] Click on the bank account.
7. [User B] Click Change bank account > Connect manually.
8. [User B] Click RHP back button twice.

Expected Result:

User B will return to Almost done page with Continue setup, Change bank account & Start over options.

Actual Result:

Add bank account page reopens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7213554_1784643784299.16.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7213554

Issue Owner

Current Issue Owner: @VickyStash

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a7806d07d9109994716ada61dd17e9153eea91ddc7c545e17550eb32948059ab

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #96241

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Issue Analysis

⚠️ This deploy blocker was auto-assigned to ShridharGoel via Expensify/App#96241, but that PR is not the cause. #96241 only changes permission checks (PolicyUtils, WalletPage, WorkspaceWorkflowsPayerPage) — it doesn't touch the bank-account setup navigation at all. It merely made this flow reachable by a Payments Admin. The actual regression comes from Expensify/App#94019 "Implement easier change of bank account" (author VickyStash, merged 2026-07-20 — one day before this blocker).

Root Cause: The "Almost done" page and the "Add bank account" page are the same navigator screen (SCREENS.REIMBURSEMENT_ACCOUNT, route bank-account/new), differing only by URL params. Clicking Change bank account calls navigateToBankAccountRoute({policyID, isChangingBankAccount: true}) — with no backTo — at src/hooks/useChangeBankAccount.ts:31. That resolves to a plain Navigation.navigate to the same route at src/libs/actions/ReimbursementAccount/navigation.ts:39. With no push/forceReplace, React Navigation merges the new params onto the existing RHP card instead of creating a new back target — so the "Almost done" state is destroyed in place. When you then click Connect manually and press back twice, you unwind onto that same bank-account/new card, which now carries isChangingBankAccount=true and therefore renders the "Add bank account" (Plaid/Manual) menu rather than "Almost done".

Recommended Fix (belongs in #94019's code): Make "Change bank account" preserve a proper back target instead of mutating the current card. Either:

• Preserve the backTo (e.g. Workflows) through useChangeBankAccount → navigateToBankAccountRoute, and/or
• Push a distinct entry rather than merging params onto the same screen (e.g. forceReplace/a dedicated route), so back returns to the "Almost done" state.

Given this is a time-sensitive deploy blocker, reassigning to VickyStash (author of #94019) — or reverting #94019 — is the fastest path.

Investigation details & evidence

The one-screen dual-state render — the same component shows both "Almost done" (Continue setup / Change bank account / Start over) and "Add bank account" (Connect with Plaid / Connect manually), switched purely by shouldShowContinueSetupButton:

• VerifiedBankAccountFlowEntryPoint.tsx:258 — title toggles almostDone vs the setup menu; both under the shared bankAccount.addBankAccount header.
• ReimbursementAccountPage.tsx:107 — const isChangingBankAccount = !!route.params?.isChangingBankAccount; forces shouldShowContinueSetupButton off, so once the card's params carry isChangingBankAccount=true it can never re-render "Almost done".

Navigation flow that breaks:

1. Workflows opens bank-account/new?policyID=X&backTo=WORKSPACE_WORKFLOWS → renders "Almost done".
2. Change bank account → navigateToBankAccountRoute({policyID, isChangingBankAccount: true}) (no backTo) → same screen, params merged → "Almost done" destroyed, now renders "Add bank account".
3. Connect manually → pushes the country/verify setup step onto the RHP.
4. Back Some initial fixes and code style updates #1 pops that step → lands on the mutated bank-account/new card → shows "Add bank account" (bug visible here).
5. Back Fix spaces #2 pops the card entirely → leaves the flow; "Almost done" is never shown.

Why it's staging-only / not production: #94019 merged 2026-07-20 and is in the 9.4.41-0 staging build; it hasn't reached production yet.

Alternatives considered: I initially checked whether #96241 (the auto-assigned PR) altered navigation — its diff is confined to permission-check helpers and never touches routing, backTo, or the ReimbursementAccount screens. Its only role in the repro is unlocking the Payments-Admin path.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/blob/53efbbdbc2a882c9218f5c7c691422f0d822b754/src/hooks/useChangeBankAccount.ts#L31) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[yuwenmemon]

Not a blocker - @VickyStash @ZhenjaHorbach @robertjchen this is relevant to your PR here: #94019