feat: render expanded chart at native resolution and add pinch-zoom via MultiGestureCanvas - #97698
Open
abbasifaizan70 wants to merge 11 commits into
Open
feat: render expanded chart at native resolution and add pinch-zoom via MultiGestureCanvas#97698abbasifaizan70 wants to merge 11 commits into
abbasifaizan70 wants to merge 11 commits into
Conversation
…ia MultiGestureCanvas
…70/Expensify into 92969-followup-zoom
melvin-bot
Bot
requested review from
flaviadefaria
and removed request for
a team
August 4, 2026 16:23
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24d931aac7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…width) in expanded charts
…high-res, let MultiGestureCanvas own all transforms
luacmartins
self-requested a review
August 6, 2026 20:54
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
|
@situchan how's review going? |
Contributor
|
@situchan any updates on the review? |
Contributor
|
Sorry missed this. Will update shortly |
Contributor
|
@abbasifaizan70 charts not rendering at all Screen.Recording.2026-08-12.at.4.50.11.PM.mov
production: Screen.Recording.2026-08-12.at.4.51.14.PM.mov |
Contributor
Author
|
@situchan Looking into these in details. |
… not cross the Skia canvas boundary
Contributor
Author
Screen.Recording.2026-08-14.at.2.34.56.AM.mp4@situchan After the fix demo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation of Change
Re-renders the expanded chart natively at its target size (via a scaled chart context) instead of raster-upscaling the design-size render, so charts stay sharp on large screens.
Adds pinch/double-tap zoom and pan to the expanded chart using MultiGestureCanvas — the same gestures as the image attachment viewer, as agreed in the follow-up discussion on #95249.
Includes unit tests for the new context-scaling logic.
Fixed Issues
$ #92969
PROPOSAL:#92969 (comment)
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-04.at.4.24.35.AM.mov
Android: mWeb Chrome
Screen_Recording_20260804_043426_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-04.at.4.12.26.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-04.at.3.57.41.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-04.at.3.42.13.AM.mp4