Skip to content

feat: render expanded chart at native resolution and add pinch-zoom via MultiGestureCanvas - #97698

Open
abbasifaizan70 wants to merge 11 commits into
Expensify:mainfrom
abbasifaizan70:92969-followup-zoom
Open

feat: render expanded chart at native resolution and add pinch-zoom via MultiGestureCanvas#97698
abbasifaizan70 wants to merge 11 commits into
Expensify:mainfrom
abbasifaizan70:92969-followup-zoom

Conversation

@abbasifaizan70

@abbasifaizan70 abbasifaizan70 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Re-renders the expanded chart natively at its target size (via a scaled chart context) instead of raster-upscaling the design-size render, so charts stay sharp on large screens.
Adds pinch/double-tap zoom and pan to the expanded chart using MultiGestureCanvas — the same gestures as the image attachment viewer, as agreed in the follow-up discussion on #95249.
Includes unit tests for the new context-scaling logic.

Fixed Issues

$ #92969
PROPOSAL:#92969 (comment)

Tests

  • Verify that no errors appear in the JS console
  1. Tap the expand button on the inline chart to open the full-screen modal.
  2. Verify the expanded chart is sharp on a large screen (text, axis labels, and lines are crisp, not blurry) and matches the inline chart's layout, only larger.
  3. Double-tap (or double-click) the chart and verify it zooms in; double-tap again to zoom back out.
  4. Pinch (mobile/trackpad) and verify the chart zooms smoothly within limits.
  5. While zoomed in, drag to pan around the chart and verify it stays within bounds.
  6. Close the modal and verify the chat is unchanged and no flicker appears.
  7. Repeat with a pie chart and verify zoom/pan work and the chart stays clipped/centered like inline.

Offline tests

Same as tests.

QA Steps

  • Verify that no errors appear in the JS console

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-04.at.4.24.35.AM.mov
Android: mWeb Chrome
Screen_Recording_20260804_043426_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-04.at.4.12.26.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-04.at.3.57.41.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-04.at.3.42.13.AM.mp4

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...ctoryChartRenderer/context/VictoryChartContext.tsx 95.45% <100.00%> (+89.89%) ⬆️
...enderers/VictoryChartRenderer/utils/parseOffset.ts 100.00% <100.00%> (ø)
src/styles/index.ts 63.00% <ø> (ø)
...Renderer/context/VictoryChartRenderArgsContext.tsx 25.00% <50.00%> (ø)
...ChartRenderer/components/VictoryChartCartesian.tsx 0.00% <0.00%> (ø)
...ctoryChartRenderer/components/VictoryChartLine.tsx 9.09% <0.00%> (ø)
...artRenderer/utils/scaleVictoryChartContextValue.ts 96.22% <96.22%> (ø)
...ictoryChartRenderer/components/VictoryChartBar.tsx 8.33% <0.00%> (-0.76%) ⬇️
...yChartRenderer/components/VictoryChartBarGroup.tsx 3.84% <0.00%> (-0.16%) ⬇️
...rs/VictoryChartRenderer/utils/parseCornerRadius.ts 0.00% <0.00%> (ø)
... and 2 more
... and 155 files with indirect coverage changes

@abbasifaizan70 abbasifaizan70 changed the title feat: render expanded chart at native resolution and add pinch-zoom v… feat: render expanded chart at native resolution and add pinch-zoom via MultiGestureCanvas Aug 3, 2026
@abbasifaizan70
abbasifaizan70 marked this pull request as ready for review August 4, 2026 16:23
@abbasifaizan70
abbasifaizan70 requested review from a team as code owners August 4, 2026 16:23
@melvin-bot
melvin-bot Bot requested a review from situchan August 4, 2026 16:23
@melvin-bot

melvin-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24d931aac7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@abbasifaizan70
abbasifaizan70 requested a review from a team as a code owner August 5, 2026 00:33
@luacmartins
luacmartins self-requested a review August 6, 2026 20:54
@situchan

situchan commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@luacmartins

Copy link
Copy Markdown
Contributor

@situchan how's review going?

@quinthar quinthar added the #ai label Aug 11, 2026
@luacmartins

Copy link
Copy Markdown
Contributor

@situchan any updates on the review?

@situchan

Copy link
Copy Markdown
Contributor

Sorry missed this. Will update shortly

@situchan

Copy link
Copy Markdown
Contributor

@abbasifaizan70 charts not rendering at all

Screen.Recording.2026-08-12.at.4.50.11.PM.mov
Screenshot 2026-08-12 at 4 53 40 PM

production:
(this also has regression. Resize is broken)

Screen.Recording.2026-08-12.at.4.51.14.PM.mov

@abbasifaizan70

Copy link
Copy Markdown
Contributor Author

@situchan Looking into these in details.

@quinthar quinthar removed the #ai label Aug 13, 2026
@abbasifaizan70

Copy link
Copy Markdown
Contributor Author
Screen.Recording.2026-08-14.at.2.34.56.AM.mp4

@situchan After the fix demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants