Expense-Reimbursement toggle changes report header and row

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: V9.4.49-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176815/test-cases/41237196
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workspace chat
3. Create a empty report
4. Open the report and duplicate the report
5. In duplicate report, tap add expenses and add a distance manual expense
6. Note expense report title briefly changes from copy of expense report to expense report
7. Open the expense
8. Toggle on and off Reimbursement toggle and note Report row and header

Expected Result:

Toggle on/off Reimbursement toggle, report row and header must not switch between copy of expense report and expense report.

Actual Result:

Toggle on/off Reimbursement toggle, report row and header switches between copy of expense report and expense report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7225667_1785857000393.Screenrecorder-2026-08-04-20-43-58-781.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7225667

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022084672716822781564
• Upwork Job ID: 2084672716822781564
• Last Price Increase: 2026-08-04

Issue Owner

Current Issue Owner: @cristipaval

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/ba3cfe1ee3aabccd775041c089a8bc25ca550dab04be167e360fce91fd524966

[MelvinBot]

Proposal

What is the root cause of that problem?

When you duplicate a report, the "Copy of …" name is stored only on report.reportName — the report is not marked as manually renamed. At the same time, the new report's title report field (expensify_text_title) is seeded from the policy as a FORMULA field.

Later, editing an expense in that report (adding it, or toggling Reimbursable) runs maybeUpdateReportNameForFormulaTitle. Because the title field is still type FORMULA (a manual rename would have nulled it out), it recomputes the name from the policy title formula and overwrites report.reportName, dropping the "Copy of …" prefix. The title layer then faithfully renders the overwritten value — hence the switch to the default "expense report" name.

Code trace (Medium confidence)

1. Duplicate sets the custom name only on report.reportName:
   src/libs/actions/IOU/Duplicate.ts:983 → createNewReport → buildNewReportOptimisticData, Report/index.ts:4154-4156.
2. The same builder seeds the report's expensify_text_title RNVP from the policy as a FORMULA field: Report/index.ts:4284 → ReportTitleUtils.ts:41-67. No manual-rename marker is set.
3. Editing an expense recomputes the report name when the title field is FORMULA: MoneyRequestBuilder.ts:1818-1823 → maybeUpdateReportNameForFormulaTitle, MoneyRequestBuilder.ts:1238-1258. Its guard even notes "Manual renames null out expensify_text_title" — but the duplicate never does that, so the guard passes and report.reportName is overwritten with the formula value.

What changes do you think we should make in order to solve the problem?

When creating a duplicated report with a custom reportName, also treat it as a manual rename so the formula recompute short-circuits: null out expensify_text_title in the new report's reportNameValuePairs (the same thing a normal rename does). With no FORMULA title field present, the guard in maybeUpdateReportNameForFormulaTitle returns early and "Copy of …" is preserved through expense edits.

The natural place is createNewReport/buildNewReportOptimisticData (Report/index.ts:4154): when an explicit reportName is passed, skip/override updateTitleFieldToMatchPolicy for that report and set expensify_text_title to null instead. Confirm the backend (CREATE_APP_REPORT) persists this as a manual title so it survives a refresh.

What alternative solutions did you explore? (Optional)

• Make maybeUpdateReportNameForFormulaTitle skip reports whose reportName was explicitly set — weaker, since it can't distinguish a real manual rename from a formula default.

---

⚠️ Repro note — could not confirm a persistent revert on web

I drove the full flow on web (create workspace → empty report → Duplicate report → add a manual Distance expense → toggle Reimbursable on/off). The title and the Reports-list row stayed "Copy of Expense Report 2026-08-04" at every point-in-time check — the revert did not persist.

The reported symptom in step 6 is that the name "briefly changes", which points to a transient optimistic flicker: the edit optimistically recomputes/overwrites report.reportName, then a subsequent Onyx/server update restores it. Point-in-time snapshots after settling would miss a sub-second flicker, so this is consistent with the code mechanism above but not independently confirmed as a lasting revert on web. It may be more pronounced/persistent on Android.

Evidence from the web run:

Step	Title observed
Duplicate opened	Copy of Expense Report 2026-08-04
After adding distance expense	Copy of Expense Report 2026-08-04
After Reimbursable ON	Copy of Expense Report 2026-08-04
After Reimbursable OFF	Copy of Expense Report 2026-08-04

Screenshots: duplicate · after add expense · reimbursable on · reimbursable off · reports list

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/97804) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @huult (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022084672716822781564

[huult]

Screen.Recording.2026-08-06.at.11.22.56.mov

I'm unable to reproduce this issue on dev, but I can still reproduce it on staging. It's possible the fix has already been applied on dev but hasn't been released to staging yet. I think we should wait for the next staging release and retest then.

[huult]

I'm still investigating the root cause.

[huult]

I think we can proceed with @MelvinBot's proposal

App/src/libs/actions/Report/index.ts

Line 4246 in 6695479

optimisticData.push(...updateTitleFieldToMatchPolicy(reportID, policy));

if (!reportName) {
    optimisticData.push(...updateTitleFieldToMatchPolicy(reportID, policy));
}

Screen.Recording.2026-08-07.at.12.37.24.mov

This should prevent a custom report name, such as "Copy of X", from being overwritten by the policy title formula.

🎀 👀 🎀 c+ reviewed.

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

Agreed — and your refinement is cleaner than what I originally proposed. 👍

My original suggestion was to seed the FORMULA title field and then null it out for a custom-named report. Your version skips the seeding entirely, which reaches the same end state more directly: when a custom reportName is passed (the duplicate "Copy of …" case), don't add expensify_text_title to the new report's rNVP at all.

if (!reportName) {
    optimisticData.push(...updateTitleFieldToMatchPolicy(reportID, policy));
}

Why this works: updateTitleFieldToMatchPolicy is what seeds the FORMULA expensify_text_title field. With no FORMULA field present, the guard in maybeUpdateReportNameForFormulaTitle short-circuits during later expense edits (add expense / toggle Reimbursable), so report.reportName is never recomputed and "Copy of …" is preserved. reportName is already in scope here — it's set on the report at Report/index.ts:4133-4134.

One thing worth confirming during implementation/QA: this only changes the optimistic data. If the backend CREATE_APP_REPORT independently seeds a FORMULA title field on the created report and pushes it back via Onyx, the FORMULA field could reappear after the server response and reintroduce the overwrite on a later edit. Your staging video suggests the fix holds, but it's worth a quick check that the name still survives a refresh + another Reimbursable toggle after the report has fully synced.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/97804) to create a draft PR with this change.
To refine: @MelvinBot <your feedback>