Fix L1 Failing Tests

[JoE11-y]

Description 📹

Several tests related to unlocking with proofs are failing due to configuration or implementation issues in the commitment hash validation logic. This is causing revert errors during the claim process for multiple tokens.

Failing Tests

• [FAIL: revert: ZeroXBridge: Invalid commitment hash] testClaimReducesTokenReserveDAI (gas: 527,631)
• [FAIL: revert: msgHash out of range] testClaimReducesTokenReserveETH (gas: 438,766)
• [FAIL: revert: msgHash out of range] testClaimReducesTokenReserveUSDC (gas: 526,570)

Helpful links

#112 (comment)
#112 (comment)

Proposed Actions ✅

1. Investigate the proof verification and commitment hash logic in the claim flow.
2. Verify that the commitment hash and msgHash are being generated and validated consistently across tests and contract logic.
3. Update configurations or logic to ensure the proof verification passes for supported tokens.
4. Run the full test suite to confirm that all failing tests are resolved.

Acceptance Criteria 🧾

• All three failing tests pass successfully.
• No regression in related claim or reserve management functionality.
• Code changes are documented clearly in the PR with details on what caused the failures and how they were fixed.

[ikemHood]

Hey @JoE11-y

I'd like to fix this test.

Please assign

[GideonBature]

Greetings, Please I would love to work on this issue. Thank you!

Recommended by OnlyDust for exceptional experience, quality, and reliability.

[Henrichy]

Hi team 👋,

I’d like to take ownership of this issue.

From the description and linked discussions, the core failures are tied to commitment hash validation and msgHash handling within the claim flow. My plan is as follows:

Deep-dive into the proof verification + commitment hash logic to identify why commitments fail for ETH, DAI, and USDC.

Align contract + test implementations so commitment hash and msgHash are consistently generated/validated across the board.

Patch configurations or update the claim logic where necessary to ensure proper verification for all supported tokens.

Run the full test suite to confirm the three failing cases pass and no regressions are introduced in claim or reserve management.

Document the fix clearly in the PR, including the root cause of the failures and the corrective changes.

This structured approach should resolve the failing tests while strengthening proof verification across the bridge. Please assign this issue to me, and I’ll provide timely progress updates. 🚀

[Ugo-X]

Assigned @GideonBature