Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX and responsivenes issues #67

Open
2 of 5 tasks
marisid opened this issue Nov 4, 2016 · 2 comments
Open
2 of 5 tasks

UX and responsivenes issues #67

marisid opened this issue Nov 4, 2016 · 2 comments
Assignees

Comments

@marisid
Copy link

marisid commented Nov 4, 2016

I really like your background image! Feels like I'm at the cinema 😄 Maybe add a gray linear gradient on top of the image to make the lights less bright? Just a suggestion. Also, a few points below:

  • Improve display and readability of the Generate button to stand out from background text on landing page (maybe add a transparent full-width background colour to the div that contains the button or change the button colour?)
  • On landing page, there is a <<<<< HEAD text on top of the 80s and 70s release buttons, probably from an unresolved merge conflict. To be removed.
  • After choosing a release period, subsequent generate click events always use the era that was picked first even if a different release period has been clicked.
  • Adding a rating scale, a source and who are the reviewers (e.g. general public?) for clarity
  • Improve responsiveness for mobile view: Generate button is too big and wraps in two lines, 2010-15 test doesn't fit in the release period button.
@marisid
Copy link
Author

marisid commented Nov 4, 2016

Another thing I noted is that the rating doesn't work for me. I'm getting random rating although I specify a certain rating category.

@emilyb7
Copy link
Contributor

emilyb7 commented Nov 4, 2016

Points 2 and 4 are fixed

@shiryz shiryz removed their assignment Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants