You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it's cool that you did makeRequest and it makes your series of get functions easy to read (lines52 - 91). It would help if you used comments etc to divide your functions up into sections. For example the bit that actually calls the waterfall is quite far from that list of get functions with stuff in between that doesn't seem as relevant (if I understand correctly).
You could also wrap it all in an IIFE so that you don't have loads of global variables.
The text was updated successfully, but these errors were encountered:
I think it's cool that you did
makeRequest
and it makes your series of get functions easy to read (lines52 - 91). It would help if you used comments etc to divide your functions up into sections. For example the bit that actually calls the waterfall is quite far from that list of get functions with stuff in between that doesn't seem as relevant (if I understand correctly).You could also wrap it all in an IIFE so that you don't have loads of global variables.
The text was updated successfully, but these errors were encountered: