Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure of app.js #70

Open
tbtommyb opened this issue Nov 4, 2016 · 0 comments
Open

Structure of app.js #70

tbtommyb opened this issue Nov 4, 2016 · 0 comments

Comments

@tbtommyb
Copy link

tbtommyb commented Nov 4, 2016

I think it's cool that you did makeRequest and it makes your series of get functions easy to read (lines52 - 91). It would help if you used comments etc to divide your functions up into sections. For example the bit that actually calls the waterfall is quite far from that list of get functions with stuff in between that doesn't seem as relevant (if I understand correctly).

You could also wrap it all in an IIFE so that you don't have loads of global variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant