You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Great reusable implementation! As it is used in a waterfall chain, perhaps pass an Error to the callback if XMLHttpRequest doesn't exist. So instead of this;
if(!httpRequest){alert('Giving up :( Cannot create an XMLHTTP instance');returnfalse;}
Use this
if(!httpRequest){cb('Giving up :( Cannot create an XMLHTTP instance');}
Otherwise the callback chain may not pick up on the 'return False' statement
The text was updated successfully, but these errors were encountered:
Great reusable implementation! As it is used in a waterfall chain, perhaps pass an Error to the callback if XMLHttpRequest doesn't exist. So instead of this;
Use this
Otherwise the callback chain may not pick up on the 'return False' statement
The text was updated successfully, but these errors were encountered: