Fix BleedingEdgeIncludePurifier to use random value on temporary file to avoid crash (rectorphp#3396)

* Fix BleedingEdgeIncludePurifier to use random value on temporary file to avoid crash

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* ignore phpstan notice on phpstan 1.10.0

* fixed by check recursive call

* [ci-review] Rector Rectify

* fixed by check recursive call

---------

Co-authored-by: GitHub Action <[email protected]>

Author: samsonasik

packages/NodeCollector/NodeAnalyzer/ArrayCallableMethodMatcher.php

@@ -180,10 +180,12 @@ private function resolveClassConstFetchType(ClassConstFetch $classConstFetch): M
         }
 
         $extendedMethodReflection = $classReflection->getMethod(MethodName::CONSTRUCT, $scope);
-        $parametersAcceptor = ParametersAcceptorSelector::selectSingle($extendedMethodReflection->getVariants());
+        $parametersAcceptorWithPhpDocs = ParametersAcceptorSelector::selectSingle(
+            $extendedMethodReflection->getVariants()
+        );
 
-        foreach ($parametersAcceptor->getParameters() as $parameterReflection) {
-            if ($parameterReflection->getDefaultValue() === null) {
+        foreach ($parametersAcceptorWithPhpDocs->getParameters() as $parameterReflectionWithPhpDoc) {
+            if ($parameterReflectionWithPhpDoc->getDefaultValue() === null) {
                 return new MixedType();
             }
         }

packages/NodeTypeResolver/DependencyInjection/BleedingEdgeIncludePurifier.php

@@ -53,6 +53,8 @@ private function createTemporaryFilePath(string $filePath): string
         $fileDirectory = dirname($filePath);
         $baseFileName = pathinfo($filePath, PATHINFO_BASENAME);
 
-        return $fileDirectory . '/temp_' . $baseFileName;
+        $randomBytes = random_bytes(10);
+        $randomString = bin2hex($randomBytes);
+        return $fileDirectory . '/temp_' . $randomString . '_' . $baseFileName;
     }
 }

packages/PhpAttribute/NodeAnalyzer/ExprParameterReflectionTypeCorrector.php

@@ -49,10 +49,12 @@ public function correctItemsByAttributeClass(array|Array_ $items, string $attrib
 
         $extendedMethodReflection = $attributeClassReflection->getConstructor();
 
-        $parametersAcceptor = ParametersAcceptorSelector::selectSingle($extendedMethodReflection->getVariants());
+        $parametersAcceptorWithPhpDocs = ParametersAcceptorSelector::selectSingle(
+            $extendedMethodReflection->getVariants()
+        );
 
         foreach ($items as $name => $item) {
-            foreach ($parametersAcceptor->getParameters() as $parameterReflection) {
+            foreach ($parametersAcceptorWithPhpDocs->getParameters() as $parameterReflection) {
                 $correctedItem = $this->correctItemByParameterReflection($name, $item, $parameterReflection);
                 if (! $correctedItem instanceof Expr) {
                     continue;

phpstan.neon

@@ -805,3 +805,10 @@ parameters:
 
         - '#Call to static method Webmozart\\Assert\\Assert\:\:(allIsAOf|isAOf|assertInstanceOf|allIsInstanceOf)(.*?) will always evaluate to true#'
         - '#Call to method PHPUnit\\Framework\\Assert\:\:assertInstanceOf\(\) with (.*?) will always evaluate to true#'
+
+        - '#Doing instanceof PHPStan\\Type\\.* is error\-prone and deprecated(\. Use Type\:\:.*\(\) (or .* )?instead)?#'
+
+        # phpstan 1.10.0
+        - '#Call to deprecated method getDirectClassNames\(\) of class PHPStan\\Type\\TypeUtils.*#'
+        - '#Parameter 3 should use "PHPStan\\Reflection\\ParameterReflectionWithPhpDocs" type as the only type passed to this method#'
+        - '#Parameters should use "PHPStan\\Reflection\\ParameterReflectionWithPhpDocs\|PhpParser\\Node\\Param" types as the only types passed to this method#'

rules/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector.php

@@ -183,10 +183,12 @@ private function resolveExceptionArgumentPosition(Name $exceptionName): ?int
         }
 
         $extendedMethodReflection = $classReflection->getConstructor();
-        $parametersAcceptor = ParametersAcceptorSelector::selectSingle($extendedMethodReflection->getVariants());
+        $parametersAcceptorWithPhpDocs = ParametersAcceptorSelector::selectSingle(
+            $extendedMethodReflection->getVariants()
+        );
 
-        foreach ($parametersAcceptor->getParameters() as $position => $parameterReflection) {
-            $parameterType = $parameterReflection->getType();
+        foreach ($parametersAcceptorWithPhpDocs->getParameters() as $position => $parameterReflectionWithPhpDoc) {
+            $parameterType = $parameterReflectionWithPhpDoc->getType();
             if (! $parameterType instanceof TypeWithClassName) {
                 continue;
             }

rules/DeadCode/Comparator/CurrentAndParentClassMethodComparator.php

@@ -157,11 +157,13 @@ private function areParameterDefaultsDifferent(
         ClassMethod $classMethod,
         ExtendedMethodReflection $extendedMethodReflection
     ): bool {
-        $parametersAcceptor = ParametersAcceptorSelector::selectSingle($extendedMethodReflection->getVariants());
+        $parametersAcceptorWithPhpDocs = ParametersAcceptorSelector::selectSingle(
+            $extendedMethodReflection->getVariants()
+        );
 
-        foreach ($parametersAcceptor->getParameters() as $key => $parameterReflection) {
+        foreach ($parametersAcceptorWithPhpDocs->getParameters() as $key => $parameterReflectionWithPhpDoc) {
             if (! isset($classMethod->params[$key])) {
-                if ($parameterReflection->getDefaultValue() !== null) {
+                if ($parameterReflectionWithPhpDoc->getDefaultValue() !== null) {
                     continue;
                 }
 
@@ -171,7 +173,7 @@ private function areParameterDefaultsDifferent(
             $methodParam = $classMethod->params[$key];
 
             if ($this->parameterDefaultsComparator->areDefaultValuesDifferent(
-                $parameterReflection,
+                $parameterReflectionWithPhpDoc,
                 $methodParam
             )) {
                 return true;

rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php

@@ -7,6 +7,7 @@
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NullType;
@@ -15,6 +16,9 @@
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeWithClassName;
 use PHPStan\Type\UnionType;
+use Rector\Core\PhpParser\AstResolver;
+use Rector\Core\PhpParser\Comparing\NodeComparator;
+use Rector\Core\PhpParser\Node\BetterNodeFinder;
 use Rector\NodeCollector\ValueObject\ArrayCallable;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\NodeTypeResolver\PHPStan\Type\TypeFactory;
@@ -25,6 +29,9 @@ public function __construct(
         private readonly NodeTypeResolver $nodeTypeResolver,
         private readonly TypeFactory $typeFactory,
         private readonly ReflectionProvider $reflectionProvider,
+        private readonly BetterNodeFinder $betterNodeFinder,
+        private readonly AstResolver $astResolver,
+        private readonly NodeComparator $nodeComparator
     ) {
     }
 
@@ -41,6 +48,10 @@ public function resolveStrictTypesFromCalls(array $calls): array
                 continue;
             }
 
+            if ($this->isRecursiveCall($call)) {
+                return [];
+            }
+
             foreach ($call->args as $position => $arg) {
                 if (! $arg instanceof Arg) {
                     continue;
@@ -54,6 +65,18 @@ public function resolveStrictTypesFromCalls(array $calls): array
         return $this->unionToSingleType($staticTypesByArgumentPosition);
     }
 
+    private function isRecursiveCall(MethodCall|StaticCall $call): bool
+    {
+        $parentClassMethod = $this->betterNodeFinder->findParentType($call, ClassMethod::class);
+
+        if (! $parentClassMethod instanceof ClassMethod) {
+            return false;
+        }
+
+        $classMethod = $this->astResolver->resolveClassMethodFromCall($call);
+        return $this->nodeComparator->areNodesEqual($parentClassMethod, $classMethod);
+    }
+
     private function resolveStrictArgValueType(Arg $arg): Type
     {
         $argValueType = $this->nodeTypeResolver->getNativeType($arg->value);