POJOPropertyBuilder always treats all fields as "renamed"

[dmoebius]

jackson-databind 2.3.0 or later, POJOPropertyBuilder lines 681-688 says:

        String explName = node.explicitName;
        ...
        // different from default name?
        if (explName.equals(_name)) { // nope, skip
            continue;
        }

but _name is of type PropertyName, so this check is always false. That's why all properties are marked as "renamed" in method findNewName().

I would have sent a patch but I don't know what's the right way to fix it.

[dmoebius]

Maybe this is the right fix:

    if (explName.equals(_name.getSimpleName())) { // nope, skip

but then the namespace is disregarded.

[cowtowncoder]

Ah. Good point, yes, definitely a bug.. I will try to fix this; I agree this is bit subtle, esp. with respect to namespaces. So I should have a look.

FWIW, this is due to refactoring to make PropertyName replace use of Strings (mostly to allow passing of XML namespaces; but possibly other scoping for non-JSON formats too).

[cowtowncoder]

Ok: I think suggested fix is better than leaving things as are. Only wish there was a unit test to verify this helps with a problem.