Remove meaningless checks and properties in KNAI. #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k163377
added a commit
to ProjectMapK/jackson-module-kogera
that referenced
this pull request
Jan 11, 2023
Member
|
Should this be closed? It's against 2.13, version that is no longer maintained. |
k163377
force-pushed
the
remove_ignoredClasses
branch
from
35a917a to
065e7fd
Compare
Contributor
Author
|
I was unsure of the intent of this process, but since I am sure it is useless at this point, I will merge the deletion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hasCreatorAnnotationwas checking if thedeclaringClasswas included in theignoredClassesForImplyingJsonCreator.On the other hand, since
ignoredClassesForImplyingJsonCreatorwas always theemptySet, this check would always returnfalse.(Since
KotlinNameAnnotationIntrospectoris aninternalclass, it is not initialized with any external arguments.)This PR removes meaningless checks and removes
ignoredClassesForImplyingJsonCreator.However, it seems to me that this property should be set via
KotlinFeature.Do you have any background on this?