From 17a11d72588baf80043bc5acdf836f0a84bdb521 Mon Sep 17 00:00:00 2001 From: Owen Hammer <10822281+hammerOwen@users.noreply.github.com> Date: Fri, 7 Feb 2025 11:27:20 -0500 Subject: [PATCH 1/3] docs: correct node cache example --- docs/docs/clients/server-side.mdx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/docs/clients/server-side.mdx b/docs/docs/clients/server-side.mdx index 61379725c70d..12a59cef491a 100644 --- a/docs/docs/clients/server-side.mdx +++ b/docs/docs/clients/server-side.mdx @@ -1903,11 +1903,10 @@ const redisClient = redis.createClient({ const redisFlagsmithCache = { async get(key: string): Promise { const cachedValue = await redisClient.get(key); - return Promise.resolve(cachedValue && JSON.parse(cachedValue)); + return cachedValue && new Flags(JSON.parse(cachedValue)); }, async set(key: string, value: Flags): Promise { await redisClient.set(key, JSON.stringify(value), { EX: 60 }); - return Promise.resolve(); }, } satisfies FlagsmithCache; From e91e25606293d9e4b96a5275cb3b7bbb52cc8ded Mon Sep 17 00:00:00 2001 From: Owen Hammer <10822281+hammerOwen@users.noreply.github.com> Date: Thu, 13 Feb 2025 09:53:48 -0500 Subject: [PATCH 2/3] docs: correct import and use if on return --- docs/docs/clients/server-side.mdx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/docs/clients/server-side.mdx b/docs/docs/clients/server-side.mdx index 12a59cef491a..51086788b9e3 100644 --- a/docs/docs/clients/server-side.mdx +++ b/docs/docs/clients/server-side.mdx @@ -1892,8 +1892,8 @@ interface. For example, this cache implementation uses Redis as a backing store: ```typescript -import { Flagsmith } from 'flagsmith-nodejs'; -import type { BaseOfflineHandler, EnvironmentModel, Flags, FlagsmithCache } from 'flagsmith-nodejs'; +import { Flagsmith, Flags } from 'flagsmith-nodejs'; +import type { BaseOfflineHandler, EnvironmentModel, FlagsmithCache } from 'flagsmith-nodejs'; import * as redis from 'redis'; const redisClient = redis.createClient({ @@ -1903,7 +1903,9 @@ const redisClient = redis.createClient({ const redisFlagsmithCache = { async get(key: string): Promise { const cachedValue = await redisClient.get(key); - return cachedValue && new Flags(JSON.parse(cachedValue)); + if(cachedValue) { + return new Flags(JSON.parse(cachedValue)); + } }, async set(key: string, value: Flags): Promise { await redisClient.set(key, JSON.stringify(value), { EX: 60 }); From eee26c986010163922dc9b0abc84bc05027a6de3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20L=C3=B3pez=20Dato?= Date: Fri, 14 Feb 2025 11:04:25 +0100 Subject: [PATCH 3/3] nit --- docs/docs/clients/server-side.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/clients/server-side.mdx b/docs/docs/clients/server-side.mdx index 51086788b9e3..b14a4861a5c8 100644 --- a/docs/docs/clients/server-side.mdx +++ b/docs/docs/clients/server-side.mdx @@ -1903,7 +1903,7 @@ const redisClient = redis.createClient({ const redisFlagsmithCache = { async get(key: string): Promise { const cachedValue = await redisClient.get(key); - if(cachedValue) { + if (cachedValue) { return new Flags(JSON.parse(cachedValue)); } },