explain why pathNames isn't ref

Author: tomysshadow

FlashpointSecurePlayer/DownloadsBefore.cs

@@ -13,7 +13,7 @@
 using static FlashpointSecurePlayer.Shared.FlashpointSecurePlayerSection.TemplatesElementCollection.TemplateElement.ModificationsElement.DownloadBeforeElementCollection;
 
 namespace FlashpointSecurePlayer {
-    class DownloadsBefore : Modifications {
+    public class DownloadsBefore : Modifications {
         public DownloadsBefore(EventHandler importStart, EventHandler importStop) : base(importStart, importStop) { }
 
         private void Activate() { }

FlashpointSecurePlayer/EnvironmentVariables.cs

@@ -15,7 +15,7 @@
 using static FlashpointSecurePlayer.Shared.FlashpointSecurePlayerSection.TemplatesElementCollection.TemplateElement.ModificationsElement.EnvironmentVariablesElementCollection;
 
 namespace FlashpointSecurePlayer {
-    class EnvironmentVariables : Modifications {
+    public class EnvironmentVariables : Modifications {
         private const string __COMPAT_LAYER = nameof(__COMPAT_LAYER);
         private IList<string> UnmodifiableComparableNames { get; } = new List<string> { FP_STARTUP_PATH, FP_HTDOCS_FILE }.AsReadOnly();
         private readonly object activationLock = new object();

FlashpointSecurePlayer/FlashpointSecurePlayer.csproj

@@ -148,6 +148,7 @@
       <DependentUpon>Settings.settings</DependentUpon>
       <DesignTimeSharedInput>True</DesignTimeSharedInput>
     </Compile>
+    <None Include="README.md" />
   </ItemGroup>
   <ItemGroup>
     <None Include="App.config">

FlashpointSecurePlayer/OldCPUSimulator.cs

@@ -14,7 +14,7 @@
 using static FlashpointSecurePlayer.Shared.FlashpointSecurePlayerSection.TemplatesElementCollection.TemplateElement.ModificationsElement.OldCPUSimulatorElement;
 
 namespace FlashpointSecurePlayer {
-    class OldCPUSimulator : Modifications {
+    public class OldCPUSimulator : Modifications {
         public OldCPUSimulator(EventHandler importStart, EventHandler importStop) : base(importStart, importStop) { }
 
         public bool TestRunningWithOldCPUSimulator() {

FlashpointSecurePlayer/README.md

@@ -9,8 +9,6 @@ Flashpoint Secure Player requires a Template and a URL. The Template determines
 
 `FlashpointSecurePlayer TemplateName URL`
 
-This player has bugs. Help me find them! If you've found a bug, report anything unusual as an issue.
-
 # Templates
 Templates determine what to do with a URL. Every Template has its own configuration file. The configuration files may be hosted on the Flashpoint Server, making it easy to integrate into the existing Flashpoint curation flow. A number of sample configuration files are included alongside the player in the FlashpointSecurePlayerConfigs folder.
 

FlashpointSecurePlayer/RunAsAdministrator.cs

@@ -9,7 +9,7 @@
 using static FlashpointSecurePlayer.Shared.FlashpointSecurePlayerSection.TemplatesElementCollection;
 
 namespace FlashpointSecurePlayer {
-    class RunAsAdministrator : Modifications {
+    public class RunAsAdministrator : Modifications {
         public RunAsAdministrator(EventHandler importStart, EventHandler importStop) : base(importStart, importStop) { }
 
         public void Activate(string templateName, bool runAsAdministrator) {

FlashpointSecurePlayer/Shared.cs

@@ -2797,6 +2797,11 @@ public static string RemoveTrailingSlash(string path) {
             //return path.TrimEnd('\\');
         }
 
+        // pathNames is intentionally not ref
+        // it's a class, so it's already a reference type
+        // it can be null, which is supported,
+        // but it is intentionally not an optional argument, because
+        // you should pass it in if you have one
         public static object LengthenValue(object value, string path, PathNames pathNames) {
             // since it's a value we'll just check it exists
             if (!(value is string valueString)) {

FlashpointSecurePlayer/SingleInstance.cs

@@ -16,7 +16,7 @@
 using static FlashpointSecurePlayer.Shared.FlashpointSecurePlayerSection.TemplatesElementCollection.TemplateElement.ModificationsElement.SingleInstanceElement;
 
 namespace FlashpointSecurePlayer {
-    class SingleInstance : Modifications {
+    public class SingleInstance : Modifications {
         public SingleInstance(EventHandler importStart, EventHandler importStop) : base(importStart, importStop) { }
 
         // function to create a real MessageBox which