-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow HTTP security options to be set via device settings #317
Comments
As a first iteration, just being able to do this via the settings file would be valuable. This has just been requested by - https://app-eu1.hubspot.com/contacts/26586079/record/0-2/12971827644 |
We don't expose the settings file for the user to edit. One quick iteration would be to allow those settings to be set via the device.yml file - the only file we let the user edit. The bigger iteration is providing a more consistent UX in the platform UI for modifying these settings. |
Using the device.yml would work in this (https://app-eu1.hubspot.com/contacts/26586079/record/0-2/12971827644) customer's case @knolleary |
Duplication of: FlowFuse/flowfuse#4204 |
@joepavitt can you clarify the task in this iteration pls? Nick states:
and
|
The iterations are as stated:
|
Rob, that link has no details about the request (it seems to lead only to the customer details). Can you let me know what they asked for? I ask because from my understanding, this 1st iteration proposed would only permit setting single basic auth user in |
@knolleary to clarify 1st iteration. As this will permit user to set e.g. raw - take what the user enters (requires knowledge of yaml object formatting)
e.g. curated - specific props, not nested, forgoes yaml formatting knowledge (i.e. simplified but not an exact translation of Node-RED docs https://nodered.org/docs/user-guide/runtime/securing-node-red)
Either way, I would recommend we sanity check the values and return a valid/not valid result when parsing the yaml file (as we do currently for missing values when provisioning etc) |
Option 1 gets my vote. Will check to see what you've put in the PR :)
|
Description
As a: flow creator
I want to: secure http end points served by the device agent
So that: they are secured to the same standard as hosted-instances
We can easily provide the
basic auth
option as that is hardcoded into the settings file. Provided FF Team auth is trickier as it requires oauth bounce to the platform and all the bits that entails. Need to think about how to achieve that securely when the device is running outside the security boundary of the platformAcceptance Criteria
Requested By
The text was updated successfully, but these errors were encountered: