Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Device Agent container to run not as root #342

Closed
hardillb opened this issue Jan 31, 2025 · 2 comments · Fixed by #349
Closed

Allow Device Agent container to run not as root #342

hardillb opened this issue Jan 31, 2025 · 2 comments · Fixed by #349
Labels
feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do

Comments

@hardillb
Copy link
Contributor

Description

Currently the device agent container runs as root

The working directory is /opt/flowfuse-device which is owned by root:root with permission drwxr-xr-x

This means only root can write to the working directory.

If the container is started with --user uid:gid other the 0:0 then the device agent can not write the project dir, package.json or any of the other parts.

Current work around would be to mount a volume that the supplied uid/gid can write to on /opt/flowfuse-device

Requested By
@hardillb hardillb added feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do labels Jan 31, 2025
@knolleary knolleary mentioned this issue Jan 31, 2025
Closed
@hardillb
Copy link
Contributor Author

Should be able to just make /opt/flowfuse-device writeable by all.

@hardillb
Copy link
Contributor Author

hardillb commented Feb 4, 2025

We should also move the npm cache to being under /opt/flowfuse-device to ensure it can be written by the user.

We've done this for stack containers.

hardillb added a commit that referenced this issue Feb 12, 2025
@hardillb
Allow container to run as none root user
5765e75 
fixes #342
hardillb added a commit that referenced this issue Feb 12, 2025
@hardillb
Allow none root users
aad0e8c 
fixes #342
@hardillb hardillb mentioned this issue Feb 12, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do
Projects
☁️ Product Planning
Status: Closed / Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docker as none root user FlowFuse/device-agent
1 participant
@hardillb