Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device restart whilst in Dev Mode should pickup settings changes #5069

Open
knolleary opened this issue Jan 30, 2025 · 0 comments
Open

Device restart whilst in Dev Mode should pickup settings changes #5069

knolleary opened this issue Jan 30, 2025 · 0 comments
Labels
area:device Device specific work needs-triage Needs looking at to decide what to do size:S - 2 Sizing estimation point

Comments

@knolleary
Copy link
Member

Description

There are some rough edges around how we handle updating settings for Devices.

  • If a Device is in Fleet mode, any changes to its settings (env vars etc) trigger a restart of the device instantly.
    • Hosted instances require a manual restart to pickup changes
  • If a Device is in Developer mode, any changes to its settings are ignored until it is taken out of developer mode.
    • Doing an explicit 'restart' from the action menu doesn't pickup and settings changes

This second item is a real pain point. If you are developing on the device, you are likely to want to set new env vars etc. Having to toggle in/out of developer mode is a big pain and risks losing work when the fleet-mode target snapshot overwrites what was there.

I believe that doing a 'restart' whilst in Developer Mode should check for new settings and apply them. This should not change the flows.

Epic/Story

No response

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@knolleary knolleary added area:device Device specific work size:S - 2 Sizing estimation point labels Jan 30, 2025
@knolleary knolleary added the needs-triage Needs looking at to decide what to do label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:device Device specific work needs-triage Needs looking at to decide what to do size:S - 2 Sizing estimation point
Projects
Status: No status
Development

No branches or pull requests

1 participant