Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form node, required field should show a star (*) #1578

Open
dastriebel opened this issue Jan 13, 2025 · 2 comments
Open

Form node, required field should show a star (*) #1578

dastriebel opened this issue Jan 13, 2025 · 2 comments
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do

Comments

@dastriebel
Copy link

Current Behavior

with dashboard 1, if a field is required a star (*) is shown beside the label. with dashborad 2.0 this star is not shown

Expected Behavior

same behavior as with the original dashboard

Steps To Reproduce

No response

Environment

  • Dashboard version:
  • Node-RED version:
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@dastriebel dastriebel added bug Something isn't working needs-triage Needs looking at to decide what to do labels Jan 13, 2025
@bartbutenaers
Copy link
Contributor

@dastriebel,
Indeed it seems that the form fields behave not all in the same way.
I have created a sample form containing all the different types:

image

Some inconsistenties I see:

  • The last 2 (date and time) have a black text and icon.
  • The elements become red after being clicked. Before clicking on them, it is not really obvious that they are required.
  • Currently the labels get a postfix is required. Do you mean that this postfix should be replaced by (*)?

Bart

@dastriebel
Copy link
Author

dastriebel commented Jan 13, 2025

Hi Bart

  • The postfix is required is nice, but only shown after leaving the field ==> it's an error message.

  • The star (*) (beside the label ) is a behaivior, as i know it all over the internet ==> it's an indicator, that the field is required.

so i would add the start to the label but also keep the postfix.
keep in mind, that the label is optional, so if no label is defined, the star should be shown anyway

Dieter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Projects
Status: Backlog
Development

No branches or pull requests

2 participants